Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bob codegen deletes view specs when codegen type is all #736

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atlj
Copy link
Collaborator

@atlj atlj commented Dec 24, 2024

Summary

Fixes #728

The codegen patcher script was deleting the whole facebook namespace when the codegen type was all or module. This was not a problem when the type was module but when the type was all, view manager specs were also getting removed.s

Test plan

  1. Create a new turbo module
  2. Set codegen type to all
  3. Add turbo module specs
  4. Run yarn bob build --target codegen
  5. Make sure android/generated/java/com/facebook/react exists and has view manager specs

@atlj atlj requested a review from satya164 December 24, 2024 13:09
@atlj atlj enabled auto-merge December 24, 2024 13:36
@sidorchukandrew
Copy link

Thank you for fixing this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building Fabric View + Turbo Module
3 participants