fix: bob codegen deletes view specs when codegen type is all #736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #728
The codegen patcher script was deleting the whole
facebook
namespace when the codegen type was all or module. This was not a problem when the type was module but when the type was all, view manager specs were also getting removed.sTest plan
yarn bob build --target codegen
android/generated/java/com/facebook/react
exists and has view manager specs