Skip to content

Commit 388ad09

Browse files
feat(android): upgrade SDK versions and build tools (#742)
<!-- Please provide enough information so that others can review your pull request. --> <!-- Keep pull requests small and focused on a single change. --> ### Summary There are some outdated values, I synced them with what is currently inside template: https://github.com/react-native-community/template/blob/f4aa4a9817b4381a108e19040fe3b3515cc531bc/template/android/build.gradle ### Test plan CI
1 parent 64a469c commit 388ad09

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

packages/create-react-native-library/templates/native-common/android/build.gradle

+5-8
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
buildscript {
2-
// Buildscript is evaluated before everything else so we can't use getExtOrDefault
3-
def kotlin_version = rootProject.ext.has("kotlinVersion") ? rootProject.ext.get("kotlinVersion") : project.properties["<%- project.name -%>_kotlinVersion"]
2+
ext.getExtOrDefault = {name ->
3+
return rootProject.ext.has(name) ? rootProject.ext.get(name) : project.properties['<%- project.name -%>_' + name]
4+
}
45

56
repositories {
67
google()
78
mavenCentral()
89
}
910

1011
dependencies {
11-
classpath "com.android.tools.build:gradle:7.2.1"
12+
classpath "com.android.tools.build:gradle:8.7.2"
1213
// noinspection DifferentKotlinGradleVersion
13-
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
14+
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:${getExtOrDefault('kotlinVersion')}"
1415
}
1516
}
1617

@@ -32,10 +33,6 @@ if (isNewArchitectureEnabled()) {
3233
apply plugin: "com.facebook.react"
3334
}
3435

35-
def getExtOrDefault(name) {
36-
return rootProject.ext.has(name) ? rootProject.ext.get(name) : project.properties["<%- project.name -%>_" + name]
37-
}
38-
3936
def getExtOrIntegerDefault(name) {
4037
return rootProject.ext.has(name) ? rootProject.ext.get(name) : (project.properties["<%- project.name -%>_" + name]).toInteger()
4138
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
<%- project.name -%>_kotlinVersion=1.7.0
2-
<%- project.name -%>_minSdkVersion=21
3-
<%- project.name -%>_targetSdkVersion=31
4-
<%- project.name -%>_compileSdkVersion=31
5-
<%- project.name -%>_ndkversion=21.4.7075529
1+
<%- project.name -%>_kotlinVersion=2.0.21
2+
<%- project.name -%>_minSdkVersion=24
3+
<%- project.name -%>_targetSdkVersion=34
4+
<%- project.name -%>_compileSdkVersion=35
5+
<%- project.name -%>_ndkversion=27.1.12297006

0 commit comments

Comments
 (0)