fix: remove slack new chat message #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/core/src/plugins/logging.ts
Outdated
| @@ -23,3 +25,27 @@ export const loggingPlugin: ApplicationPlugin = { | |||
| } | |||
| }, | |||
| }; | |||
|
|
|||
| export const contextLoggerBuilder = (fieldsToLog: (keyof RequestContext)[]): ApplicationPlugin => { | |||
There was a problem hiding this comment.
Can we move it into separate PR, and tweak changset to reflect this?
Q1w1N
force-pushed
the
fix/slack-new-chat
branch
from
eb9deaa to
3cf414c
Compare
mdjastrzebski
changed the title
| import { ApplicationPlugin, MessageResponse } from '@callstack/byorg-core'; | ||
| import { logger } from '@callstack/byorg-utils'; | ||
|
|
||
| export const slackThreadNormalizerPlugin: ApplicationPlugin = { |
There was a problem hiding this comment.
Add /** xx */ comment to explain the purpose of this plugin. Also update docs to mention in.
mdjastrzebski
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes "New chat\n" from slack. Also added super cool "context logger builder" plugin
Test plan
Tested with examples