fix(value): use kind as ultimate source of truth (#6)

Author: callmehiphop

index.ts

@@ -101,16 +101,16 @@ export const value = {
    * @returns {*}
    */
   decode(value: Value): JsonValue {
-    if (value.listValue) {
-      return list.decode(value.listValue);
+    switch(value.kind) {
+      case 'listValue':
+        return list.decode(value.listValue);
+      case 'structValue':
+        return struct.decode(value.structValue);
+      case 'nullValue':
+        return null;
+      default:
+        return value[value.kind] as JsonValue;
     }
-    if (value.structValue) {
-      return struct.decode(value.structValue);
-    }
-    if (typeof value.nullValue !== 'undefined') {
-      return null;
-    }
-    return value[value.kind] as JsonValue;
   }
 };
 

test.ts

@@ -169,6 +169,18 @@ test('value.decode - boolValue', t => {
   t.is(actual, true);
 });
 
+// https://github.com/callmehiphop/pb-util/issues/5
+test('value.decode - multiple values', t => {
+  const encodedValue = {
+    kind: 'stringValue',
+    stringValue: 'foo',
+    nullValue: 0
+  };
+
+  const actual = value.decode(encodedValue);
+  t.is(actual, 'foo');
+});
+
 test('list.encode', t => {
   const actual = list.encode(arr);
   t.deepEqual(actual, listValue);