Add GetActivityTaskList and GetWorkflowTaskList utils to replace WithTaskListMapper utils (#1292)

What changed?

Remove WithTasklist utils introduced in #1286
Instead, users should use the new GetTaskList and With*TaskList APIs.

For future as discussed with @Groxx, it's better to have a functional API to replace all "With*".

For example:
ExecuteChildWorkflow(ctx, type, child.Args(all, args), child.WorkflowID("asdf'))

Why?
With**TaskList APIs are confusing and it's better to remove it

Author: shijiesheng

internal/workflow.go

@@ -1413,16 +1413,14 @@ func WithWorkflowTaskList(ctx Context, name string) Context {
 	return ctx1
 }
 
-// WithWorkflowTaskListMapper returns a copy of context and changes workflow tasklist with mapper function.
-func WithWorkflowTaskListMapper(ctx Context, mapper func(string) string) Context {
-	ctx1 := setWorkflowEnvOptionsIfNotExist(ctx)
-	var taskList string
-	if getWorkflowEnvOptions(ctx1).taskListName != nil {
-		taskList = *getWorkflowEnvOptions(ctx1).taskListName
+// GetWorkflowTaskList retrieves current workflow tasklist from context
+func GetWorkflowTaskList(ctx Context) *string {
+	wo := getWorkflowEnvOptions(ctx)
+	if wo == nil || wo.taskListName == nil {
+		return nil
 	}
-	newTaskList := mapper(taskList)
-	getWorkflowEnvOptions(ctx1).taskListName = &newTaskList
-	return ctx1
+	tl := *wo.taskListName // copy
+	return &tl
 }
 
 // WithWorkflowID adds a workflowID to the context.
@@ -1813,12 +1811,14 @@ func WithTaskList(ctx Context, name string) Context {
 	return ctx1
 }
 
-// WithTaskListMapper makes a copy of the context and apply the tasklist mapper function
-// Note this shall not confuse with WithWorkflowTaskListMapper. This is the tasklist for activities.
-func WithTaskListMapper(ctx Context, mapper func(string) string) Context {
-	ctx1 := setActivityParametersIfNotExist(ctx)
-	getActivityOptions(ctx1).TaskListName = mapper(getActivityOptions(ctx1).TaskListName)
-	return ctx1
+// GetActivityTaskList retrieves tasklist info from context
+func GetActivityTaskList(ctx Context) *string {
+	ao := getActivityOptions(ctx)
+	if ao == nil {
+		return nil
+	}
+	tl := ao.TaskListName // copy
+	return &tl
 }
 
 // WithScheduleToCloseTimeout adds a timeout to the copy of the context.

workflow/activity_options.go

@@ -58,10 +58,14 @@ func WithTaskList(ctx Context, name string) Context {
 	return internal.WithTaskList(ctx, name)
 }
 
-// WithTaskListMapper makes a copy of current context and update the tasklist with mapper function.
-// Note this is the tasklist for activity tasklist. For workflow tasklist, use WithWorkflowTaskListMapper
-func WithTaskListMapper(ctx Context, mapper func(string) string) Context {
-	return internal.WithTaskListMapper(ctx, mapper)
+// GetActivityTaskList returns tasklist in the Context's current ActivityOptions,
+// or workflow.GetInfo(ctx).TaskListName if not set or empty
+func GetActivityTaskList(ctx Context) string {
+	tl := internal.GetActivityTaskList(ctx)
+	if tl != nil && *tl != "" {
+		return *tl
+	}
+	return GetInfo(ctx).TaskListName
 }
 
 // WithScheduleToCloseTimeout makes a copy of the current context and update

workflow/workflow_options.go

@@ -42,9 +42,14 @@ func WithWorkflowTaskList(ctx Context, name string) Context {
 	return internal.WithWorkflowTaskList(ctx, name)
 }
 
-// WithWorkflowTaskListMapper returns a copy of Context with changed tasklist
-func WithWorkflowTaskListMapper(ctx Context, mapper func(name string) string) Context {
-	return internal.WithWorkflowTaskListMapper(ctx, mapper)
+// GetWorkflowTaskList returns tasklist in the Context's current ChildWorkflowOptions
+// or workflow.GetInfo(ctx).TaskListName if not set or empty.
+func GetWorkflowTaskList(ctx Context) string {
+	tl := internal.GetWorkflowTaskList(ctx)
+	if tl != nil && *tl != "" {
+		return *tl
+	}
+	return GetInfo(ctx).TaskListName
 }
 
 // WithWorkflowID adds a workflowID to the context.