Skip to content

Commit 4ebb6cf

Browse files
authored
[Build] Update target for macOS deployment (#47)
* [Build] update target for macOS deployment * Add notes
1 parent 77790b4 commit 4ebb6cf

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,8 @@ skip = ["*-win32", "*-manylinux_i686", "*-musllinux*", "pp*"]
8383

8484
# Set the environment variable for the wheel build step.
8585
# NOTE(haocheng): we enable all the optional features for the wheel build.
86-
environment = { LCS_BUILD_DIR = "{project}/src/libCacheSim/build", MACOSX_DEPLOYMENT_TARGET = "14.0", CMAKE_ARGS = "-DENABLE_3L_CACHE=ON -DENABLE_GLCACHE=ON -DENABLE_LRB=ON" }
86+
# And MACOSX_DEPLOYMENT_TARGET should be kept in sync with [tool.scikit-build.cmake].define.CMAKE_OSX_DEPLOYMENT_TARGET
87+
environment = { LCS_BUILD_DIR = "{project}/src/libCacheSim/build", MACOSX_DEPLOYMENT_TARGET = "15.0", CMAKE_ARGS = "-DENABLE_3L_CACHE=ON -DENABLE_GLCACHE=ON -DENABLE_LRB=ON" }
8788

8889
# Test that the wheel can be imported
8990
test-command = "python -c 'import libcachesim; print(\"Import successful\")'; cp -r {project}/tests .; python -m pytest tests/ -v -m 'not optional'; python -m pytest tests/ -v -m 'optional'"

0 commit comments

Comments
 (0)