Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mutation mapper default PDB url to the new PDB endpoint #51

Open
pieterlukasse opened this issue Jun 30, 2016 · 4 comments
Open

Comments

@pieterlukasse
Copy link
Member

PDB changed its endpoint for serving PDB data from http://www.rcsb.org/pdb/files/ to http://files.rcsb.org/view/ . See also cBioPortal/cbioportal#1434.

So it would be good to update mutationMapper.js code here as follows:

        function delayedInitMutationMapper(el, options, tabs, tabName)
        {
                var mutationMapper = new MutationMapper(options);
                var initialized = false;

@@ -13516,7 +13517,8 @@ function Mutation3dVis(name, options)
                        debug: false,
                        color: "white"
                },
-               pdbUri: "http://www.rcsb.org/pdb/files/", // default PDB database URI
+               //for https, use a proxy since rcsb.org is not serving https and browsers will complain about the mixed https/http content
+               pdbUri: "http://files.rcsb.org/view/",
@pieterlukasse
Copy link
Member Author

@onursumer can it be that this old url is still found in the rc branch? Is this dead code?

@pieterlukasse
Copy link
Member Author

cc @jjgao

@onursumer
Copy link
Member

Hi @pieterlukasse, this is the legacy mutation mapper, pretty much dead. We are using the correct url for the latest implementation: https://github.com/cBioPortal/cbioportal-frontend/blob/ad8769543e3642f3d15715305d47b7924043c146/src/shared/components/structureViewer/StructureVisualizer.ts#L71

@pieterlukasse
Copy link
Member Author

Thanks @onursumer . I made 2 PRs to clean this up (they are referenced to this issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants