Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor controllers #1

Open
onursumer opened this issue Apr 22, 2015 · 0 comments
Open

refactor controllers #1

onursumer opened this issue Apr 22, 2015 · 0 comments
Assignees
@onursumer

Comments

@onursumer
Copy link
Member

Looks like most of the mutation view controllers need to access almost all of the views and the components.

Instead of passing each instance as a separate parameter to the controller constructors, just pass the MutationDetailsView and MainMutationView instances. Every other instance can be accessed via these two.
@onursumer onursumer self-assigned this Apr 22, 2015
@onursumer onursumer changed the title reduce the number of controller parameters for the mutation view refactor controllers May 5, 2016
onursumer added a commit that referenced this issue May 19, 2016
@onursumer
Merge pull request #1 from JiaoJiao123/minorStyle
7bf1bea 
spell out mutation type and add radius style to info span
fedde-s pushed a commit to thehyve/mutation-mapper that referenced this issue May 27, 2016
@onursumer
factored mutation data processing out of MutationDiagram class (fixed…
eb3b63f 
… issue cBioPortal#1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onursumer onursumer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onursumer