pulley: Implement SIMD splat instruction
#9832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets a few spec tests and CLIF tests passing cc bytecodealliance#9783
alexcrichton
requested review from
abrown and
dicej
and removed request for
a team
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "cranelift", "pulley"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
abrown
approved these changes
Dec 17, 2024
| @@ -2695,6 +2695,42 @@ impl OpVisitor for Interpreter<'_> { | |||
| self.state[dst].set_u128(val); | |||
| ControlFlow::Continue(()) | |||
| } | |||
|
|
|||
| fn vsplatx8(&mut self, dst: VReg, src: XReg) -> ControlFlow<Done> { | |||
| let val = self.state[src].get_u32() as u8; | |||
There was a problem hiding this comment.
We may need get_u8 and get_u16 eventually?
There was a problem hiding this comment.
...just mulling over whether discarding the upper bits here is going to be problematic — probably not?
There was a problem hiding this comment.
I've been wondering the same yeah, I'll probably add these in a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets a few spec tests and CLIF tests passing
cc #9783