pulley: Move fp/lr out of XReg set
#9806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
requested review from
abrown and
dicej
and removed request for
a team
|
I'd like to get there with |
github-actions
bot
added
cranelift
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "isle", "pulley", "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This commit moves the `fp` and `lr` registers out of the `XReg` register
set and into the `MachineState` per-VM. These are automatically modified
and read with `push_frame` and `pop_frame`. Dedicated `xmov_{fp,lr}`
instructions were added for use in Wasmtime's trampolines which directly
read these registers.
alexcrichton
force-pushed
the
pulley-more-gpr
branch
from
d3a9667 to
f3541f7
Compare
fitzgen
approved these changes
Dec 13, 2024
Comment on lines
96
to
97
| x_reg(30) => spilltmp_reg, writable_spilltmp_reg; | ||
| x_reg(31) => spilltmp2_reg, writable_spilltmp2_reg; |
There was a problem hiding this comment.
Do we actually use spilltmp2 in cranelift's pulley backend? AFAICT, we don't. Could free up one more GPR I think.
Also unused in CLIF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the
fpandlrregisters out of theXRegregister set and into theMachineStateper-VM. These are automatically modified and read withpush_frameandpop_frame. Dedicatedxmov_{fp,lr}instructions were added for use in Wasmtime's trampolines which directly read these registers.cc #9747