-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pulley: Ungate SIMD proposal to enable more tests #9779
pulley: Ungate SIMD proposal to enable more tests #9779
Conversation
|
This commit removes the simd proposal from "known panicking compiler features" for Pulley by filling out some minor ABI bits around loads/stores of v128 in the Cranelift ABI code. This unlocks running `spec_testsuite/*.wast` in CI and expecting it to pass as otherwise everything was rejected since that test suite requires SIMD and it never even got to the Cranelift backend. This then fixes a few minor issues here and there to get existing tests passing now that they're actually being run. Some examples are: * Fix some copy/paste typos around callee-save clobbers and float registers. * Add vector load/store support to avoid panicking in ABI code (not well tested yet though). * Zero-extend the condition in `brif`'s lowering to ensure that the entire register is defined. In the future more variants of `br_if` in Pulley are probably desired. * Limit `store` lowerings to just integer types, not vector types. * Fix `Func::call` with Pulley when the callee is a host function.
de7fcc3
to
6e45fe1
Compare
This commit is similar to bytecodealliance#9779 in that it's removing a proposal from the "known list of panicking features" for Pulley to allow more tests to run on Pulley. This then fills out a few miscellaneous instructions to get a full suite of tests passing in Pulley related to memory64 and other instructions. prtest:full
prtest:full
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "cranelift", "pulley", "wasmtime:api", "wasmtime:config"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Similar to bytecodealliance#9779 this remove the `GC_TYPES` feature from the list of panicking features in Pulley. In doing so this then additionally fixes a number of panics and then adds more tests that are working. Some other minor instructions are filled out to ensure that tests are working on both 32 and 64-bit platforms.
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
To modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
This commit is similar to bytecodealliance#9779 in that it's removing a proposal from the "known list of panicking features" for Pulley to allow more tests to run on Pulley. This then fills out a few miscellaneous instructions to get a full suite of tests passing in Pulley related to memory64 and other instructions. prtest:full
This commit is similar to bytecodealliance#9779 in that it's removing a proposal from the "known list of panicking features" for Pulley to allow more tests to run on Pulley. This then fills out a few miscellaneous instructions to get a full suite of tests passing in Pulley related to memory64 and other instructions. prtest:full
Similar to bytecodealliance#9779 this remove the `GC_TYPES` feature from the list of panicking features in Pulley. In doing so this then additionally fixes a number of panics and then adds more tests that are working. Some other minor instructions are filled out to ensure that tests are working on both 32 and 64-bit platforms.
This commit is similar to bytecodealliance#9779 in that it's removing a proposal from the "known list of panicking features" for Pulley to allow more tests to run on Pulley. This then fills out a few miscellaneous instructions to get a full suite of tests passing in Pulley related to memory64 and other instructions. prtest:full
Similar to bytecodealliance#9779 this remove the `GC_TYPES` feature from the list of panicking features in Pulley. In doing so this then additionally fixes a number of panics and then adds more tests that are working. Some other minor instructions are filled out to ensure that tests are working on both 32 and 64-bit platforms.
This commit is similar to bytecodealliance#9779 in that it's removing a proposal from the "known list of panicking features" for Pulley to allow more tests to run on Pulley. This then fills out a few miscellaneous instructions to get a full suite of tests passing in Pulley related to memory64 and other instructions. prtest:full
Similar to bytecodealliance#9779 this remove the `GC_TYPES` feature from the list of panicking features in Pulley. In doing so this then additionally fixes a number of panics and then adds more tests that are working. Some other minor instructions are filled out to ensure that tests are working on both 32 and 64-bit platforms.
* pulley: Ungate memory64 feature This commit is similar to #9779 in that it's removing a proposal from the "known list of panicking features" for Pulley to allow more tests to run on Pulley. This then fills out a few miscellaneous instructions to get a full suite of tests passing in Pulley related to memory64 and other instructions. prtest:full * Add notes about spectre speculation
Similar to bytecodealliance#9779 this remove the `GC_TYPES` feature from the list of panicking features in Pulley. In doing so this then additionally fixes a number of panics and then adds more tests that are working. Some other minor instructions are filled out to ensure that tests are working on both 32 and 64-bit platforms.
* pulley: Ungate the `GC_TYPES` feature from Pulley Similar to #9779 this remove the `GC_TYPES` feature from the list of panicking features in Pulley. In doing so this then additionally fixes a number of panics and then adds more tests that are working. Some other minor instructions are filled out to ensure that tests are working on both 32 and 64-bit platforms. * Flag test as now passing
This commit removes the simd proposal from "known panicking compiler
features" for Pulley by filling out some minor ABI bits around
loads/stores of v128 in the Cranelift ABI code. This unlocks running
spec_testsuite/*.wast
in CI and expecting it to pass as otherwiseeverything was rejected since that test suite requires SIMD and it never
even got to the Cranelift backend.
This then fixes a few minor issues here and there to get existing tests
passing now that they're actually being run. Some examples are:
registers.
tested yet though).
brif
's lowering to ensure that theentire register is defined. In the future more variants of
br_if
inPulley are probably desired.
store
lowerings to just integer types, not vector types.Func::call
with Pulley when the callee is a host function.cc #9783