Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe compatibility with Control Flow #902

Closed
Thibaud1255 opened this issue Jan 3, 2025 · 3 comments
Closed

Unsafe compatibility with Control Flow #902

Thibaud1255 opened this issue Jan 3, 2025 · 3 comments

Comments

@Thibaud1255
Copy link

  • This is not a issue but a idea of enchancements.

  • The actual control flow obfuscation is stable but mess with unsafe package

  • Personal opinion: I think it's the time to implment control flow obfuscation as a flag

@mvdan
Copy link
Member

mvdan commented Jan 3, 2025

What does unsafe have to do with using a flag or not? What are you actually suggesting? This is not actionable.

@Thibaud1255
Copy link
Author

What does unsafe have to do with using a flag or not? What are you actually suggesting? This is not actionable.

  • In you main.go when you are providing a package which use unsafe package it simply broke it with "cannot resolve package.."
  • In the issue you mentionned that the ctrl flow obf need to mature enough and once done you will promote it to a flag
  • So i propose to implement it as a flag (if you don't see any mistake or missing features)
  • So i'm sorry to bother you since i use google traduction

@mvdan
Copy link
Member

mvdan commented Jan 3, 2025

In you main.go when you are providing a package which use unsafe package it simply broke it with "cannot resolve package.."

If that is the case, please file a bug report following the issue template. We need more information to resolve bugs.

In the issue you mentionned that the ctrl flow obf need to mature enough and once done you will promote it to a flag

Currently noone is actively developing that feature, so I'm inclined against it. In any case, exposing the feature via a flag has nothing to do with this bug being fixed.

@mvdan mvdan closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants