Skip to content

Commit e8ef171

Browse files
committed
blobstore: Add metrics_tag config field
WIP; more description to come
1 parent a9d0937 commit e8ef171

5 files changed

Lines changed: 441 additions & 725 deletions

File tree

MODULE.bazel.lock

Lines changed: 4 additions & 311 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/blobstore/configuration/new_blob_access.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,10 @@ func (nc *simpleNestedBlobAccessCreator) NewNestedBlobAccess(configuration *pb.B
545545
}).NewNestedBlobAccess(config.Backend, creator)
546546
case *pb.BlobAccessConfiguration_Label:
547547
if labelBackend, ok := nc.labels[backend.Label]; ok {
548-
return labelBackend, nil
548+
return BlobAccessInfo{
549+
BlobAccess: blobstore.NewMetricsBlobAccess(labelBackend.BlobAccess, clock.SystemClock, creator.GetStorageTypeName(), "label", configuration.GetMetricsTag()),
550+
DigestKeyFormat: labelBackend.DigestKeyFormat,
551+
}, nil
549552
}
550553
return BlobAccessInfo{}, status.Errorf(codes.InvalidArgument, "Label %#v not declared", backend.Label)
551554
}
@@ -555,7 +558,7 @@ func (nc *simpleNestedBlobAccessCreator) NewNestedBlobAccess(configuration *pb.B
555558
return BlobAccessInfo{}, err
556559
}
557560
return BlobAccessInfo{
558-
BlobAccess: blobstore.NewMetricsBlobAccess(backend.BlobAccess, clock.SystemClock, creator.GetStorageTypeName(), backendType),
561+
BlobAccess: blobstore.NewMetricsBlobAccess(backend.BlobAccess, clock.SystemClock, creator.GetStorageTypeName(), backendType, configuration.GetMetricsTag()),
559562
DigestKeyFormat: backend.DigestKeyFormat,
560563
}, nil
561564
}

0 commit comments

Comments
 (0)