Repository navigation
Use CEL PartialVars during AST pruning - #333
Conversation
A change in cel-go v0.30.0 revealed a latent bug in how residual expressions were computed with protovalidate-go, as `error` values terminate function call argument evaluation. The fix marks `this` as unknown and calls CEL with a `PartialVars` argument to clearly denote the desired, non-terminating, evaluation behavior.
|
@miparnisari FYI, as this addresses cel-expr/cel-go#1403 |
|
Thank you @TristonianJones! Is the |
|
Oh sweet! Thanks for the patch, @TristonianJones. Looks like there are some formatting issues, but otherwise looks good. |
|
Hi @rodaine, I believe I updated the formatting issue. Would you mind reapproving the workflow? The issue in question is a regression from cel-go v0.29.2. As @miparnisari the 'before' patch here is how things regressed, and the 'after' is restoring it to its previous performance. |
|
Thanks again! |
|
Any sense of when this will go out? We're keen to see it. |
Version 1.3.0 is now available which includes this fix. |
A change in cel-go v0.30.0 revealed a latent bug in how residual expressions were computed with protovalidate-go, as
errorvalues terminate function call argument evaluation. The fix marksthisas unknown and calls CEL with aPartialVarsargument to clearly denote the desired, non-terminating, evaluation behavior.