Repository navigation
Commit b747d8e
authored
Fix handling registry image 404 (#2691)
The caller of the modified function:
```
registryImage, imageID, err := fetchRegistryImageAndImageID(p)
if err != nil {
return release.PluginRelease{}, false, err
}
if registryImage == "" || imageID == "" {
c.logger.InfoContext(ctx, "unable to detect registry image and image ID",
slog.String("owner", identity.Owner()),
slog.String("plugin", identity.Plugin()),
slog.String("version", p.PluginVersion),
)
return release.PluginRelease{}, true, nil
}
```
So we need `fetchRegistryImageAndImageID` to be able to return `"", "",
nil`1 parent c537abe commit b747d8e
1 file changed
Lines changed: 32 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| |||
590 | 592 | | |
591 | 593 | | |
592 | 594 | | |
593 | | - | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
594 | 616 | | |
595 | 617 | | |
596 | 618 | | |
597 | 619 | | |
598 | | - | |
| 620 | + | |
599 | 621 | | |
600 | 622 | | |
601 | 623 | | |
| |||
609 | 631 | | |
610 | 632 | | |
611 | 633 | | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
0 commit comments