Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ops count is unexpectedly greater than evaluation count #1607

Closed
cre8ivejp opened this issue Mar 19, 2025 · 0 comments · Fixed by #1606
Closed

fix: ops count is unexpectedly greater than evaluation count #1607

cre8ivejp opened this issue Mar 19, 2025 · 0 comments · Fixed by #1606
Assignees
Labels
bug Something isn't working

Comments

@cre8ivejp
Copy link
Member

The evaluation and goal events are sent from the client SDK, and for many reasons, those events could get lost in the client.
So, I implemented clamping the computed rate so that it never exceeds 100% (i.e., 1.0). In other words, if you detect that the opsCount is greater than the evaluationCount, it will adjust the opsCount to be equal to the evaluationCount before calculating the rate. This way, we avoid a rate above 1.0, and the downstream logic stays consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Weekly done
Development

Successfully merging a pull request may close this issue.

1 participant