Skip to content

Only add one process.exit handler #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benlowry wants to merge 1 commit into from
Closed

Only add one process.exit handler #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const bin = './ngrok' + (platform === 'win32' ? '.exe' : '');
const ready = /starting web service.*addr=(\d+\.\d+\.\d+\.\d+:\d+)/;
const inUse = /address already in use/;

let processPromise, activeProcess;
let processPromise, activeProcess, processHasExit;

/*
ngrok process runs internal ngrok api
Expand Down Expand Up @@ -71,7 +71,10 @@ async function startProcess (opts) {
activeProcess = null;
});

process.on('exit', async () => await killProcess());
if (!processHasExit) {
process.on('exit', async () => await killProcess());
processHasExit = true;
}

try {
const url = await apiUrl;
Expand Down