You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This should take security into account. Using os.system(f"ping -c 1 {service}") to ping a service would be insecure (e.g. someone could make service be google; sudo rm -rf /)
In this case, I think subprocess.run(["ping", "-c", "1", service]) would be more secure
The text was updated successfully, but these errors were encountered:
Related to #1, and #6, because it might be a good idea to make a command that creates new services to ping, and only "bot moderators" should be able to use it
Or, instead of a healthcheck command, there could be a /ping group command which pings all services that are part of a group, and each service has an optional list of groups that it is part of (all services are part of the all group). For instance:
This should take security into account. Using
os.system(f"ping -c 1 {service}")
to ping a service would be insecure (e.g. someone could makeservice
begoogle; sudo rm -rf /
)In this case, I think
subprocess.run(["ping", "-c", "1", service])
would be more secureThe text was updated successfully, but these errors were encountered: