Updates

Author: galt-tr

services/p2p/HandleCatchupMetrics.go

@@ -102,16 +102,20 @@ func (s *Server) GetPeersForCatchup(ctx context.Context, req *p2p_api.GetPeersFo
 	// Convert to proto format
 	protoPeers := make([]*p2p_api.PeerInfoForCatchup, 0, len(peers))
 	for _, p := range peers {
+		// Calculate total attempts as sum of successes and failures
+		// InteractionAttempts is a separate counter that may not match
+		totalAttempts := p.InteractionSuccesses + p.InteractionFailures
+
 		protoPeers = append(protoPeers, &p2p_api.PeerInfoForCatchup{
 			Id:                     p.ID.String(),
 			Height:                 p.Height,
 			BlockHash:              p.BlockHash,
 			DataHubUrl:             p.DataHubURL,
 			IsHealthy:              p.IsHealthy,
-			CatchupReputationScore: p.ReputationScore,      // Map new field to API field
-			CatchupAttempts:        p.InteractionAttempts,  // Map new field to API field
-			CatchupSuccesses:       p.InteractionSuccesses, // Map new field to API field
-			CatchupFailures:        p.InteractionFailures,  // Map new field to API field
+			CatchupReputationScore: p.ReputationScore,
+			CatchupAttempts:        totalAttempts,          // Use calculated total, not InteractionAttempts
+			CatchupSuccesses:       p.InteractionSuccesses, // Number of successful interactions
+			CatchupFailures:        p.InteractionFailures,  // Number of failed interactions
 		})
 	}
 
@@ -300,9 +304,10 @@ func (s *Server) IsPeerUnhealthy(ctx context.Context, req *p2p_api.IsPeerUnhealt
 			}, nil
 		}
 
-		// Check success rate based on attempts and successes
-		if peerInfo.InteractionAttempts > 10 && peerInfo.InteractionSuccesses < peerInfo.InteractionAttempts/2 {
-			successRate := float64(peerInfo.InteractionSuccesses) / float64(peerInfo.InteractionAttempts)
+		// Check success rate based on total interactions (successes + failures)
+		totalInteractions := peerInfo.InteractionSuccesses + peerInfo.InteractionFailures
+		if totalInteractions > 10 && peerInfo.InteractionSuccesses < totalInteractions/2 {
+			successRate := float64(peerInfo.InteractionSuccesses) / float64(totalInteractions)
 			return &p2p_api.IsPeerUnhealthyResponse{
 				IsUnhealthy:     true,
 				Reason:          fmt.Sprintf("low success rate: %.2f%%", successRate*100),

services/p2p/sync_coordinator.go

@@ -96,9 +96,9 @@ func (sc *SyncCoordinator) isCaughtUp() bool {
 	// Get all peers
 	peers := sc.registry.GetAllPeers()
 
-	// Check if any peer is significantly ahead of us
+	// Check if any peer is significantly ahead of us and has a good reputation
 	for _, p := range peers {
-		if p.Height > localHeight {
+		if p.Height > localHeight && p.ReputationScore > 20 {
 			return false // At least one peer is ahead
 		}
 	}
@@ -359,22 +359,22 @@ func (sc *SyncCoordinator) handleFSMTransition(currentState *blockchain_api.FSMS
 					currentPeer, localHeight, peerInfo.Height)
 
 				// Record catchup failure for reputation tracking
-				if sc.registry != nil {
+				/* if sc.registry != nil {
 					// Get peer info to check failure count
 					peerInfo, _ := sc.registry.GetPeer(currentPeer)
 
 					// If this peer has failed multiple times recently, treat as malicious
 					// (likely on an invalid chain)
 					if peerInfo.InteractionFailures > 2 &&
-					   time.Since(peerInfo.LastInteractionFailure) < 5*time.Minute {
+						time.Since(peerInfo.LastInteractionFailure) < 5*time.Minute {
 						sc.registry.RecordMaliciousInteraction(currentPeer)
 						sc.logger.Warnf("[SyncCoordinator] Peer %s has failed %d times recently, marking as potentially malicious",
 							currentPeer, peerInfo.InteractionFailures)
 					} else {
 						sc.registry.RecordCatchupFailure(currentPeer)
 						sc.logger.Infof("[SyncCoordinator] Recorded catchup failure for peer %s (reputation will decrease)", currentPeer)
 					}
-				}
+				}*/
 
 				sc.ClearSyncPeer()
 				_ = sc.TriggerSync()
@@ -724,12 +724,12 @@ func (sc *SyncCoordinator) checkAllPeersAttempted() {
 	for _, p := range peers {
 		// Count peers that would normally be eligible
 		if p.Height > localHeight && p.IsHealthy && !p.IsBanned &&
-		   p.DataHubURL != "" && p.URLResponsive && p.ReputationScore >= 20 {
+			p.DataHubURL != "" && p.URLResponsive && p.ReputationScore >= 20 {
 			eligibleCount++
 
 			// Check if attempted recently
 			if !p.LastSyncAttempt.IsZero() &&
-			   time.Since(p.LastSyncAttempt) < syncAttemptCooldown {
+				time.Since(p.LastSyncAttempt) < syncAttemptCooldown {
 				recentlyAttemptedCount++
 			}
 		}