feat(SPV-1442) : Pagnation code handled by backend queries #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(pagination): implement server-side pagination for contacts feat(pagination): add server-side pagination for paymails feat(pagination): implement server-side pagination for access keys feat(pagination): add server-side pagination for transactions feat(pagination): implement server-side pagination for xpubs feat(hooks): create usePagination hook for centralized pagination logic feat(hooks): implement useTable hook for table state management feat(utils): add query options with pagination support for API calls fix(pagination): ensure consistent page index conversion between UI and API feat(components): add pagination support to mobile data tables
Manual Testsℹ️ Remember to ask team members to perform manual tests and to assign |
chris-4chain
reviewed
Mar 7, 2025
feat(Pagination) : Update pagination types and constants feat(usePagination) : Common hook for useRoutePagination
| original: accessKey, | ||
| getValue: (key: string) => (key === 'status' ? accessKey.status : undefined), | ||
| } as Row<AccessKeysColumns>; | ||
| } as unknown as Row<AccessKey>; |
Contributor
There was a problem hiding this comment.
Why is this necessary ? (The unknown casting)
| | ContactExtended | ||
| | PaymailExtended | ||
| | XpubExtended | ||
| | { id?: string; url?: string; status?: string }; |
Contributor
There was a problem hiding this comment.
Consider making a type for it to be consistent and to describe (by type name) what it is.
| useEffect(() => { | ||
| setExpandedItems([]); | ||
| setIsAllExpanded(false); | ||
| }, [table.getState().pagination.pageIndex, table.getState().pagination.pageSize]); |
Contributor
There was a problem hiding this comment.
You could make a local variable (constant) for the pagination state.
| const total = manualPagination && totalRecords !== undefined ? totalRecords : table.getFilteredRowModel().rows.length; | ||
|
|
||
| // Track the current page size in local state to ensure the UI stays in sync | ||
| const [currentPageSize, setCurrentPageSize] = useState<number>(table.getState().pagination.pageSize); |
Contributor
There was a problem hiding this comment.
You could also make a local const variable for table.getState().pagination
Comment on lines
+33
to
+46
| // Initialize currentPageSize on mount and when table changes | ||
| useEffect(() => { | ||
| setCurrentPageSize(table.getState().pagination.pageSize); | ||
| }, [table]); | ||
|
|
||
| // Update local state when table pagination state changes | ||
| useEffect(() => { | ||
| // Always update the local state to match the table's page size | ||
| setCurrentPageSize(table.getState().pagination.pageSize); | ||
| }, [table.getState().pagination.pageSize]); | ||
|
|
||
| useEffect(() => { | ||
| setCurrentPageSize(table.getState().pagination.pageSize); | ||
| }, [table.getState().pagination]); |
Contributor
There was a problem hiding this comment.
It can be one useEffect with those three in one dependency list.
Comment on lines
+86
to
+88
| export function useRoutePagination<TRouter extends AnyRouter = RegisteredRouter, const TFrom extends string = string>( | ||
| routeID: ConstrainLiteral<TFrom, RouteIds<TRouter['routeTree']>>, | ||
| ) { |
Comment on lines
+89
to
+107
| // Local filter state for input field | ||
| const [filter, setFilter] = useState<string>(xpubId || ''); | ||
| const [debouncedFilter] = useDebounce(filter, 500); | ||
|
|
||
| // Update URL when the debounced filter changes | ||
| useEffect(() => { | ||
| navigate({ | ||
| search: (old) => ({ | ||
| ...old, | ||
| xpubId: debouncedFilter || undefined, | ||
| }), | ||
| replace: true, | ||
| }); | ||
| }, [debouncedFilter, navigate]); | ||
|
|
||
| // Sync filter input when URL xpubId changes | ||
| useEffect(() => { | ||
| setFilter(xpubId || ''); | ||
| }, [xpubId]); |
Contributor
There was a problem hiding this comment.
Since my last PR, the Search component does "debouncing". I think, useSearchParam hook should be used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(pagination): implement server-side pagination for contacts
feat(pagination): add server-side pagination for paymails
feat(pagination): implement server-side pagination for access keys
feat(pagination): add server-side pagination for transactions
feat(pagination): implement server-side pagination for xpubs
feat(hooks): create usePagination hook for centralized pagination logic
feat(hooks): implement useTable hook for table state management
feat(utils): add query options with pagination support for API calls
fix(pagination): ensure consistent page index conversion between UI and API
feat(components): add pagination support to mobile data tables
Pull Request Checklist