Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Buffer objects from requests where it makes sense #89

Open
myndzi opened this issue Jun 16, 2015 · 5 comments
Open

Return Buffer objects from requests where it makes sense #89

myndzi opened this issue Jun 16, 2015 · 5 comments

Comments

@myndzi
Copy link

myndzi commented Jun 16, 2015

See: http://stackoverflow.com/questions/30869460/node-js-browserify-error-on-parsing-tar-file/30878794#30878794, browserify/stream-browserify#8

It would be nice if this module emitted actual instances of Buffer so that it is compatible with other streams, specifically for .pipe

@feross
Copy link
Member

feross commented Jun 16, 2015

+1

@jhiesey
Copy link

jhiesey commented Jun 16, 2015

I'm actually in the process of writing a replacement for http-browserify with much more compatible stream support. It looks like @substack hasn't had the time to maintain this module, and its behavior is quite different from the native node http module in some important ways.

I should have an initial version on github within a day or two.

@tejasshah93
Copy link

+1 (Problem faced. SO question poster.)

@feross
Copy link
Member

feross commented Jun 16, 2015

@jhiesey Returning Buffer instead of string by default, making responseType optional (and defaulting to binary), and using new streams, would all be amazing changes!

@feross
Copy link
Member

feross commented Jul 8, 2015

Link to potential http-browserify replacement is here: https://github.com/jhiesey/httpstream (it fixes this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants