Support res.setEncoding and non-text response types
#21
Comments
|
+1 |
|
See #10 |
|
So, is there a plan to merge the PR? |
|
Would there be any value to throwing or at least logging an error if it is not +1 either way. |
jamestalmage
added a commit
to jamestalmage/node-github
that referenced
this issue
Jun 30, 2015
The main issue preventing browserify usage was computed paths
in require statements: `require("./" + someVariable)`. Those have
all been eliminated.
This patch only adds browser support for `v3.0.0` (see the throwing
code in `/index.js` where it states exactly that to understand why).
Hint: it's related to computed paths again.
There were also a number of issues in `browserify-http`, and
`browserify-https` that I needed to code around to get things working:
- https://github.com/substack/https-browserify/pull/1
- browserify/http-browserify#90
- browserify/http-browserify#21
- browserify/http-browserify#10
|
+1 |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Response data in http-browserify seems to default to text. In node http it seems to default to buffer. Independent of defaults, the node version supports
setEncodingso you can change the type of the response. The browserify version should do the same.The text was updated successfully, but these errors were encountered: