Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEAD request not working on Edge #104

Open
KAYLukas opened this issue Feb 9, 2017 · 0 comments
Open

HEAD request not working on Edge #104

KAYLukas opened this issue Feb 9, 2017 · 0 comments

Comments

@KAYLukas
Copy link

KAYLukas commented Feb 9, 2017

When doing a HEAD request with the http library, the javascript just crashes and does not give me any answers.

I tried debugging it myself and found that the library uses fetch to fetch the head. The response of this message is given to IncomingMessage. IncomingMessage assumes that a response has a body. In the case of Edge, the body is just null, because a HEAD request has no body.

Nonetheless, this is accessed in anyway:

var reader = response.body.getReader()
		function read () {
			reader.read().then(function (result) {
				if (self._destroyed)
					return
				if (result.done) {
					self.push(null)
					return
				}
				self.push(new Buffer(result.value))
				read()
			}).catch(function(err) {
				self.emit('error', err)
			})
		}

And libraries crashes, causing the HEAD request to hang indefinitely.

To be able to use my own code I added a monkey fix, to temporarily make edge work:

window.fetch_old = window.fetch
window.fetch = function () {
    var result = window.fetch_old.apply(null, arguments);
    result.then_old = result.then;
    result.then = function (callback) {
        return result.then_old(function(response) {
            if(response.body === null){
                var body = { "getReader" : function () {
                 return {
                     "read" : function (){
                         return {
                             "then" : function (callback){
                                 callback({"done":true});
                                 return {"catch" : function(){}};
                             }
                         }
                     }
                 }   
                }};
                //override body....
                var handler = {
                    get: function(target, name) {
                        if(name === "body"){
                            return body;
                        }
                        return target[name];
                    }
                };
                var response_new = new Proxy(response, handler);
                return callback(response_new);
            }
            return callback(response);
        });
    }
    return result;
};

But obviously, it would be great if this could be fixed in the library, instead of my ugly hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant