Skip to content

Commit 18cde3b

Browse files
authored
test: fix remaining release protocol handshake fixtures (#2909)
1 parent 5beaca7 commit 18cde3b

2 files changed

Lines changed: 12 additions & 7 deletions

File tree

‎packages/extension/tests/rpc-client.test.ts‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,15 @@ import { StackContextManager } from "@opentelemetry/sdk-trace-web";
33
import { describe, expect, it, vi } from "vitest";
44
import { JSONRPCRequestSchema } from "@browserbasehq/stagehand-protocol/json-rpc/schemas";
55
import { StagehandMethods } from "@browserbasehq/stagehand-protocol/schema-registry";
6+
import { STAGEHAND_PROTOCOL_VERSION } from "@browserbasehq/stagehand-protocol/schemas";
67
import { ChromeRuntimeClient } from "../clients/chromeRuntimeClient.ts";
78
import { RPCClient } from "../clients/rpcClient.ts";
89
import { createStagehandRuntime } from "../runtime.ts";
910
import { RPCRouter } from "../rpcRouter.ts";
1011

12+
const [protocolMajor, protocolMinor, protocolPatch] =
13+
STAGEHAND_PROTOCOL_VERSION.split(".").map(Number);
14+
1115
describe("worker RPCClient", () => {
1216
function createRuntime() {
1317
return createStagehandRuntime(
@@ -315,10 +319,10 @@ describe("worker RPCClient", () => {
315319
});
316320

317321
it.each([
318-
["1.0.9", true, undefined],
319-
["1.1.0", false, "protocol-server-too-old"],
320-
["2.0.0", false, "protocol-major-mismatch"],
321-
["1.0.0-beta.1", false, "protocol-prerelease-mismatch"],
322+
[`${protocolMajor}.${protocolMinor}.${protocolPatch + 1}`, true, undefined],
323+
[`${protocolMajor}.${protocolMinor + 1}.0`, false, "protocol-server-too-old"],
324+
[`${protocolMajor + 1}.0.0`, false, "protocol-major-mismatch"],
325+
[`${STAGEHAND_PROTOCOL_VERSION}-beta.1`, false, "protocol-prerelease-mismatch"],
322326
] as const)(
323327
"negotiates client protocol %s through the stagehand.init wire handshake",
324328
async (protocolVersion, compatible, reason) => {

‎packages/extension/tests/rpc-router.test.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import type { CdpWebSocketCloseEvent, CdpWebSocketTransport } from "../understud
2121
import type { Page } from "../understudy/page.ts";
2222

2323
const EMPTY_METRICS = new StagehandMetricsAccumulator().snapshot();
24+
const [protocolMajor, protocolMinor] = STAGEHAND_PROTOCOL_VERSION.split(".").map(Number);
2425

2526
afterEach(() => vi.restoreAllMocks());
2627

@@ -328,9 +329,9 @@ describe("Stagehand RPC router", () => {
328329
});
329330

330331
it.each([
331-
["1.1.0", "protocol-server-too-old"],
332-
["2.0.0", "protocol-major-mismatch"],
333-
["1.0.0-beta.1", "protocol-prerelease-mismatch"],
332+
[`${protocolMajor}.${protocolMinor + 1}.0`, "protocol-server-too-old"],
333+
[`${protocolMajor + 1}.0.0`, "protocol-major-mismatch"],
334+
[`${STAGEHAND_PROTOCOL_VERSION}-beta.1`, "protocol-prerelease-mismatch"],
334335
] as const)("rejects incompatible client protocol %s", async (protocolVersion, reason) => {
335336
const initializeStagehand = vi.fn(async () => ({ initialized: true as const, pages: [] }));
336337
const router = new RPCRouter(createStagehandRuntime(), { initializeStagehand });

0 commit comments

Comments
 (0)