Skip to content

Commit 72c2c8c

Browse files
committed
only assume role if doing webby OIDC thing. access key doesn't use that. move up AWS stuff for faster test
1 parent 141300c commit 72c2c8c

File tree

1 file changed

+12
-13
lines changed

1 file changed

+12
-13
lines changed

.github/workflows/makefile.yml

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,17 @@ jobs:
2121
node-version: '24'
2222
cache: 'npm'
2323

24+
- name: "Configure AWS Credentials"
25+
uses: aws-actions/[email protected]
26+
with:
27+
aws-region: us-east-1
28+
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
29+
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
30+
31+
- name: S3 test
32+
run: |
33+
aws s3 ls s3://pyret-horizon/new-horizons
34+
2435
- name: Install Chrome and ChromeDriver
2536
run: |
2637
# Get latest stable Chrome version
@@ -101,16 +112,4 @@ jobs:
101112
else
102113
echo "Running all tests"
103114
npm run mocha
104-
fi
105-
106-
- name: "Configure AWS Credentials"
107-
uses: aws-actions/[email protected]
108-
with:
109-
aws-region: us-east-1
110-
role-to-assume: arn:aws:iam::279230647316:user/github-actions
111-
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
112-
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
113-
114-
- name: Deploy
115-
run: |
116-
aws s3 ls s3://pyret-horizon/new-horizons
115+
fi

0 commit comments

Comments
 (0)