Consider removing pylint as a dependency of the firecloud package.
#168
Comments
|
I am having the same issue. I am getting |
14 tasks
dheiman
added a commit
that referenced
this issue
Jul 25, 2022
* Changed Dockerfile base image to python 3.10 * Fixed Python 3.10 incompatibility issues (fixes #170) * pylint set to minimum version 2.0.0 (fixes #168) api.py: * added `__patch()` helper to simplify adding wrappers for `PATCH` API calls * enhanced error checking to use the more robust json decoder in the `requests` module * `upload_entities()`: added `delete_empty` parameter * `get_entities_query()`: added `filter_operator` and `fields` parameters * `create_submission()`: added `deleteIntermediateOutputFiles`, `useReferenceDisks`, `memoryRetryMultiplier`, `workflowFailureMode`, and `userComment` fields (fixes #165, #169) * `create_workspace()`: added `noWorkspaceOwner` and `bucketLocation` fields and enabled use of multiple authorization domains (fixes #171) * new helper functions: `_attr_vlcreate()` and `_attr_erlcreate()` for creating list attribute via `update_workspace_attributes()` and `update_entity()` (resolves #99) * fixed bugs in existing helper functionss `_attr_ladd()` and `_attr_lrem()` * new functions: - `delete_entities_of_type()` - `rename_entity()` - `rename_entity_type()` - `rename_entity_type_attribute()` * updated and cleaned up documentation for multiple functions `fiss.py`: * new functions: - `entity_rename()` - `attr_rename()` * function updates: - helper `_entity_paginator()` updated to take advantage of the `fields` parameter to speed up queries - `config_start()` updated to use new `api.create_submission()` fields - `attr_get()` now returns formatted arrays for list attributes in workspaces - `attr_set()` updated to enable creation of value and reference list attributes - `attr_delete()` updated to be completely type agnostic (previously only guaranteed to work on entity types in the firecloud model) - `space_new()` updated to allow multiple authorization domains and set the bucket region for the new workspace * Cleaned up return of Terra errors to be more human-readable `highlevel_tests.py`: * updated include new rename functions * fixed bugs that were due to inaccurate API docs `lowlevel_tests.py`: * added test for `get_entities_query()`.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
firecloudpackage depends on pylint in both requirements.txt and setup.py but it appears to only be used a build time to lint the code.This dependency is causing a potential security vulnerability in packages that depend on
firecloud. For example, see all-of-us/workbench-snippets#70Consider removing pylint as a dependency of the
firecloudpackage or, at a minimum, remove the package version pin fromsetup.pyso that users are not forced to downgrade to an old version of pylint.The text was updated successfully, but these errors were encountered: