Automatically including discriminator in criteria

[kevindente]

One thing that threw me about using this plugin is that querying from a derived model doesn't automatically scope the query to the type identified by the discriminator key. So if Car extends Vehicle, Car.find() includes all Vehicles, not just cars. Have you considered patching queries to include the filter automatically? Or alternatively, provide special finder methods that scope a query to the specific type.

[chopachom]

+1, it actually should save the whole inheritance chain to discriminator key to work properly, so if we have a car it should include something like ['Vehicle', 'Car']

[sanbor]

+1 this is a must have.

If I don't want to use discriminator I could just use the parent model.

Example: Vehicle.find to match all vehicles, and Car.find to match only Vehicles with discriminatorKey === 'Vechicle'.

[Oleg2tor]

+1

[bloudermilk]

This would be great.

[lucadom]

+1

[bobmoff]

Just bumped in to the same problem. Kind of loosing the point of extending if I have to manually add the _type property to all queries.

So: +1

These comments are almost a year old so I guess the hope for a fix is tiny.

[miguelcobain]

Definitely +1

[langfors]

Pretty please +1

[bobmoff]

Here is a fork with this: https://github.com/okpanda/mongoose-schema-extend

[israelcrux]

@bobmoff I moved to okpanda's. This one is really dead. Thanks for sharing!

[sieira]

Will check it soon