fix(pg-cloudflare): safely end closed sockets (#3735)

Author: pratik-desgn

packages/pg-cloudflare/src/index.ts

@@ -107,7 +107,7 @@ export class CloudflareSocket extends EventEmitter {
   end(data = Buffer.alloc(0), encoding: BufferEncoding = 'utf8', callback: (...args: unknown[]) => void = () => {}) {
     log('ending CF socket')
     this.write(data, encoding, (err) => {
-      this._cfSocket!.close()
+      this._cfSocket?.close()
       if (callback) callback(err)
     })
     return this

packages/pg-esm-test/pg-cloudflare.test.js

@@ -6,4 +6,16 @@ describe('pg-cloudflare', () => {
   it('should export CloudflareSocket constructor', () => {
     assert.ok(new CloudflareSocket())
   })
+
+  it('should safely end after the underlying socket has closed', async () => {
+    const socket = new CloudflareSocket()
+    const underlyingSocket = { closed: Promise.resolve() }
+    socket._cfSocket = underlyingSocket
+    socket._addClosedHandler()
+
+    await underlyingSocket.closed
+    assert.equal(socket._cfSocket, null)
+
+    assert.doesNotThrow(() => socket.end())
+  })
 })