fix(pg-protocol): read ParameterDescription type OIDs as unsigned (#3728)

parseField() already reads dataTypeID as uint32 for RowDescription
(with a regression test covering OIDs above 2^31-1), but
parseParameterDescriptionMessage() was still using the signed int32
reader for the same kind of value, so custom extension types with a
high OID would come back negative in ParameterDescriptionMessage.dataTypeIDs.

Author: pratik-desgn

packages/pg-protocol/src/inbound-parser.test.ts

@@ -161,6 +161,8 @@ const oneParameterDescBuf = buffers.parameterDescription([1111])
 
 const twoParameterDescBuf = buffers.parameterDescription([2222, 3333])
 
+const bigOidParameterDescBuf = buffers.parameterDescription([3000000003])
+
 const expectedEmptyParameterDescriptionMessage = {
   name: 'parameterDescription',
   length: 6,
@@ -182,6 +184,13 @@ const expectedTwoParameterMessage = {
   dataTypeIDs: [2222, 3333],
 }
 
+const expectedBigOidParameterMessage = {
+  name: 'parameterDescription',
+  length: 10,
+  parameterCount: 1,
+  dataTypeIDs: [3000000003],
+}
+
 const testForMessage = function (buffer: Buffer, expectedMessage: any) {
   it('receives and parses ' + expectedMessage.name, async () => {
     const messages = await parseBuffers([buffer])
@@ -288,6 +297,7 @@ describe('PgPacketStream', function () {
     testForMessage(emptyParameterDescriptionBuffer, expectedEmptyParameterDescriptionMessage)
     testForMessage(oneParameterDescBuf, expectedOneParameterMessage)
     testForMessage(twoParameterDescBuf, expectedTwoParameterMessage)
+    testForMessage(bigOidParameterDescBuf, expectedBigOidParameterMessage)
   })
 
   describe('parsing rows', function () {

packages/pg-protocol/src/parser.ts

@@ -300,7 +300,8 @@ const parseParameterDescriptionMessage = (reader: BufferReader) => {
   const parameterCount = reader.int16()
   const message = new ParameterDescriptionMessage(LATEINIT_LENGTH, parameterCount)
   for (let i = 0; i < parameterCount; i++) {
-    message.dataTypeIDs[i] = reader.int32()
+    // OIDs are unsigned, same as dataTypeID in parseField above
+    message.dataTypeIDs[i] = reader.uint32()
   }
   return message
 }