ItemProvider's Items are edited by ShopGuiPlus

[emanondev]

Items given by ItemProvider are changed after ItemProvider provide them

Example if ItemProvider provide a POTION (Material) item with no base potion effects like water bottle, the base potion data is changed and a INSTANT_HEAL as Base Effect is added

Steps to reproduce:

1. Create an item provider as specified
2. On loadItem() return a water bottle
3. Put that item on a Shop and reload the plugin
4. Open the shop and see that your water bottle gained INSTANT_HEAL effect

Server version: git-Paper-299 (MC: 1.18.2)
ShopGuiPlus: 1.76.0

[brcdev]

Needs investigation

[brcdev]

Bug confirmed. It's not just API bug, it affects items added in regular way as well.