refactor: apply code review suggestions for passport module

Author: vicentevendramin

docs/pt-br/utilities.md

@@ -454,7 +454,6 @@ import { formatPassport } from '@brazilian-utils/brazilian-utils';
 
 formatPassport('ab123456'); // 'AB123456'
 formatPassport('AB-123.456'); // 'AB123456'
-formatPassport('12345678'); // null
 ```
 
 ## generatePassport

docs/utilities.md

@@ -454,7 +454,6 @@ import { formatPassport } from '@brazilian-utils/brazilian-utils';
 
 formatPassport('ab123456'); // 'AB123456'
 formatPassport('AB-123.456'); // 'AB123456'
-formatPassport('12345678'); // null
 ```
 
 ## generatePassport

src/format-passport/format-passport.test.ts

@@ -1,23 +1,14 @@
-import { beforeEach, describe, expect, test, vi } from "vitest";
-import { isValidPassport } from "../is-valid-passport/is-valid-passport";
+import { describe, expect, test } from "vitest";
 import { formatPassport } from "./format-passport";
 
 describe("formatPassport", () => {
-	beforeEach(() => {
-		vi.restoreAllMocks();
-	});
+    describe("should return the formatted passport", () => {
+        test("when passport is valid", () => {
+            expect(formatPassport("AB123456")).toBe("AB123456");
+        });
 
-	describe("should return the formatted passport", () => {
-		test("when passport is valid", () => {
-			vi.spyOn({ isValidPassport }, "isValidPassport").mockReturnValue(true);
-			expect(formatPassport("yz 987654")).toBe("YZ987654");
-		});
-	});
-
-	describe("should return null", () => {
-		test("when passport is not valid", () => {
-			vi.spyOn({ isValidPassport }, "isValidPassport").mockReturnValue(false);
-			expect(formatPassport("acd12736")).toBeNull();
-		});
-	});
+        test("when passport has lowercase letters", () => {
+            expect(formatPassport("acd12736")).toBe("ACD12736");
+        });
+    });
 });

src/format-passport/format-passport.ts

@@ -1,19 +1,16 @@
-import { isValidPassport } from "../is-valid-passport/is-valid-passport";
-import { parsePassport } from "../parse-passport/parse-passport";
-
 /**
  * Formats a Brazilian passport number for display.
- * Returns the passport uppercased and without symbols, or null if invalid.
+ * Converts to uppercase and removes all non-alphanumeric characters.
  *
  * @param passport - A Brazilian passport number (any case, possibly with symbols).
- * @returns The formatted passport number (uppercase, no symbols), or null if invalid.
+ * @returns The formatted passport number (uppercase, no symbols), or an empty string if invalid.
  *
  * @example
- * formatPassport("Ab123456") // "AB123456"
- * formatPassport("Ab-123456") // "AB123456"
- * formatPassport("111111") // null
+ * formatPassport("ab123456") // "AB123456"
+ * formatPassport("AB-123.456") // "AB123456"
+ * formatPassport("") // ""
  */
-export const formatPassport = (passport: string): string | null => {
-	const cleaned = parsePassport(passport.toUpperCase());
-	return isValidPassport(cleaned) ? cleaned : null;
+export const formatPassport = (passport: string): string => {
+	if (!passport || typeof passport !== "string") return "";
+	return passport.toUpperCase().replace(/[^A-Z0-9]/g, "");
 };

src/generate-passport/constants.ts

@@ -0,0 +1,4 @@
+export const LETTERS_LENGTH = 2;
+export const DIGITS_LENGTH = 6;
+export const ALPHABET_LENGTH = 26;
+export const CHAR_CODE_A = 65;

src/generate-passport/generate-passport.test.ts

@@ -3,9 +3,9 @@ import { isValidPassport } from "../is-valid-passport/is-valid-passport";
 import { generatePassport } from "./generate-passport";
 
 describe("generatePassport", () => {
-	test("should always generate a valid passport", () => {
-		for (let i = 0; i < 10_000; i++) {
-			expect(isValidPassport(generatePassport())).toBe(true);
-		}
-	});
+    test("should always generate a valid passport", () => {
+        for (let i = 0; i < 100; i++) {
+            expect(isValidPassport(generatePassport())).toBe(true);
+        }
+    });
 });

src/generate-passport/generate-passport.ts

@@ -1,3 +1,6 @@
+import { generateRandomNumber } from "../_internals/generate-random-number/generate-random-number";
+import { LETTERS_LENGTH, DIGITS_LENGTH, ALPHABET_LENGTH, CHAR_CODE_A } from "./constants";
+
 /**
  * Generates a random valid Brazilian passport number.
  *
@@ -8,13 +11,11 @@
  * generatePassport() // "ZS840088"
  */
 export const generatePassport = (): string => {
-	const letters = Array.from({ length: 2 }, () =>
-		String.fromCharCode(65 + Math.floor(Math.random() * 26)),
-	).join("");
+    const letters = Array.from({ length: LETTERS_LENGTH }, () =>
+        String.fromCharCode(CHAR_CODE_A + Math.floor(Math.random() * ALPHABET_LENGTH)),
+    ).join("");
 
-	const digits = Array.from({ length: 6 }, () =>
-		Math.floor(Math.random() * 10),
-	).join("");
+    const digits = generateRandomNumber(DIGITS_LENGTH);
 
-	return `${letters}${digits}`;
+    return `${letters}${digits}`;
 };

src/is-valid-passport/constants.ts

@@ -0,0 +1 @@
+export const PASSPORT_REGEX = /^[A-Z]{2}[0-9]{6}$/;

src/is-valid-passport/is-valid-passport.ts

@@ -1,3 +1,5 @@
+import { PASSPORT_REGEX } from "./constants";
+
 /**
  * Checks if a Brazilian passport number is valid.
  * To be considered valid, the input must be a string containing exactly two
@@ -14,7 +16,7 @@
  * isValidPassport("12345678") // false
  * isValidPassport("DC-221345") // false
  */
-export const isValidPassport = (passport: string): boolean => {
-	if (typeof passport !== "string") return false;
-	return /^[A-Z]{2}[0-9]{6}$/.test(passport);
+export const isValidPassport = (passport: string | number): boolean => {
+    if (passport === null || passport === undefined) return false;
+    return PASSPORT_REGEX.test(String(passport));
 };

src/parse-passport/parse-passport.ts

@@ -9,5 +9,7 @@
  * parsePassport("Ab-123456") // "Ab123456"
  * parsePassport("Ab -. 123456") // "Ab123456"
  */
-export const parsePassport = (passport: string): string =>
-	passport.replace(/[\s.-]/g, "");
+export const parsePassport = (passport: string): string => {
+	if (!passport || typeof passport !== "string") return "";
+	return passport.replace(/[^a-zA-Z0-9]/g, "");
+};