Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated separator when vertical tab has only pinned tabs #43375

Open
1 of 6 tasks
simonhong opened this issue Jan 20, 2025 · 0 comments · May be fixed by brave/brave-core#27284
Open
1 of 6 tasks

Duplicated separator when vertical tab has only pinned tabs #43375

simonhong opened this issue Jan 20, 2025 · 0 comments · May be fixed by brave/brave-core#27284
Assignees
@simonhong
Labels
bug feature/vertical-tabs OS/Desktop QA/Yes release-notes/exclude

Comments

@simonhong
Copy link
Member

Description

When vertical tab has pinned and non-pinned tabs both:
Image

When vertical tab has only pinned tab, separator is thicker because pinned tab area separator and new tab button separator are adjacent.

Image

If non-pinned tabs count is zero, we should only have new tab buttons's separator

Steps to reproduce

  1. Enable vertical tab mode
  2. Create one pinned tab and several non-pinned tabs
  3. Close all non-pinned tabs

Actual result

Thicker separator between pinned tabs area and new tab button

Expected result

1px height separator between pinned tabs and new tab button

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.76.19 Chromium: 132.0.6834.83 (Official Build) nightly (x86_64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc @rebron @aguscruiz @brave/qa-team
@simonhong simonhong self-assigned this Jan 20, 2025
simonhong added a commit to brave/brave-core that referenced this issue Jan 21, 2025
@simonhong
Show separator between pinned and unpinned when both are not empty
5f5f1f3 
fix brave/brave-browser#43375
simonhong added a commit to brave/brave-core that referenced this issue Jan 21, 2025
@simonhong
Show separator between pinned and unpinned when both are not empty
d53a825 
fix brave/brave-browser#43375
simonhong added a commit to brave/brave-core that referenced this issue Jan 21, 2025
@simonhong
Show separator between pinned and unpinned when both are not empty
d40e813 
fix brave/brave-browser#43375

We're using pinned tab container's bottom border as a separator from
unpinned tab container. It should be drawn when only both are not empty.
This was referenced Jan 21, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/vertical-tabs OS/Desktop QA/Yes release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show separator between pinned and unpinned when both are not empty brave/brave-core
1 participant
@simonhong