Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

componentWillReceiveProps warning with React 16.9 #44

Closed
erwanriou opened this issue Dec 3, 2019 · 5 comments
Closed

componentWillReceiveProps warning with React 16.9 #44

erwanriou opened this issue Dec 3, 2019 · 5 comments

Comments

@erwanriou
Copy link

erwanriou commented Dec 3, 2019

Due to the use of react-motion, this library have issue with the componentWillReceiveProps warning and might be deprecated in a further version of react.

I suggest to enhance the project to avoid using react-motion that seems an abandonned project. See below the link of the issue on react-motion that haven't been fix.

chenglou/react-motion#569

why not trying using this library instead? https://github.com/react-spring/react-spring

@braposo
Copy link
Owner

braposo commented Dec 5, 2019

Hey @erwanriou, thanks for opening the issue!

Yes I've thought a few times about that over the years (#7) but haven't had the time and the need to create a new version with a different library.

I'll probably do that soon though as it makes sense to use the benefits of hooks as well so there will probably be a new major version at some point that can only be used in React 16.3+

@erwanriou
Copy link
Author

Cool! Yeah lets make the transition to the hooks :)

@jacobclyne
Copy link

Any updates for this issue?

@jacksonblankenship
Copy link

I'm still getting this warning in the console, any plans to fix?

@braposo
Copy link
Owner

braposo commented Aug 25, 2020

Sorry, haven't been able to focus on this library in the past months but I'm now back to work on v3 so this will be fixed as part of that update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants