Filter first, the the rest

[KES777]

@@ -270,10 +274,10 @@ class FormDataJson {
      * @return {*}
      */
     function output () {
+      if (options.skipEmpty) returnObject = removeEmpty(returnObject) || (options.flatList ? [] : {})
       if (options.arrayify) {
         returnObject = arrayify(returnObject)
       }
-      if (options.skipEmpty) returnObject = removeEmpty(returnObject) || (options.flatList ? [] : {})
       return returnObject
     }

This is more faster because the next modification functions need to work with less amount of elements.

[brainfoolong]

It doesnt make a difference and is a micro optimization with no benefit. When you have both flags activated, there is no measurable improvement at all.

No need to change this, as it doesn't make any real world difference.

[KES777]

It does.

Lets examine then this next real life case.
Eg. if we have 100 inputs and only one is filled, first the code above will try to arrayify 100 elements and then process another 100 items to filter out 99 of them.
In total 200 items were processed.

In case if this patch will be applied. Those 99 items will be filtered first and 1 left.
Then this 1 item will be 'arrayify'ed.
In total 101 items were processed in this case.

If optimized it becomes twice! efficient.

2. Example.
   Very often HTML forms has hidden fields, which are never visible to user and, probably, not filled. Thus it would be nice to filter out these hidden fields before attempting to arrayify them.

In my case I have:

  Company[Phone][0][id]
  Company[Phone][0][phone]
  Company[Phone][1][id]
  Company[Phone][1][phone]
  Company[Phone][X][id]
  Company[Phone][X][phone]

Where [X] inputs are hidden and could be cloned as many times as user want to add more phones to his company. These cloned fields become [2], [3] and so on.

Otherwise when form if submitted arrayify will fail, because X is not number and could not be parsed.

Probably the last example is just my corner case, but with first example you can see that with optimization code works twice! faster.

Thanks.

[brainfoolong]

You are right, it was my head wrongly wrapped around. I'll someday implement this.