We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
danger
Describe the bug:
When running make test the tests for the danger package fail.
make test
What version of Go are you using (go version)?
go version
$ go version go version go1.16.3 linux/amd64
To Reproduce:
Run make test on master branch
master
Expected behavior:
All tests pass
Screenshots:
goos: linux goarch: amd64 pkg: github.com/bradford-hamilton/dora/pkg/danger cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz BenchmarkStringToBytesSafe BenchmarkStringToBytesSafe-16 1450934 828.0 ns/op 1545.91 MB/s 1280 B/op 1 allocs/op BenchmarkBytesToStringSafe BenchmarkBytesToStringSafe-16 2114690 567.8 ns/op 2254.30 MB/s 1280 B/op 1 allocs/op BenchmarkStringToBytesDanger fatal error: checkptr: converted pointer straddles multiple allocations goroutine 51 [running]: runtime.throw(0x5f4361, 0x3a) /usr/local/go/src/runtime/panic.go:1117 +0x72 fp=0xc000067db8 sp=0xc000067d88 pc=0x4699b2 runtime.checkptrAlignment(0xc00023aa00, 0x5bc260, 0x1) /usr/local/go/src/runtime/checkptr.go:20 +0xc9 fp=0xc000067de8 sp=0xc000067db8 pc=0x439469 github.com/bradford-hamilton/dora/pkg/danger.StringToBytes(...) /workspaces/dora/pkg/danger/danger.go:33 github.com/bradford-hamilton/dora/pkg/danger.BenchmarkStringToBytesDanger(0xc00016a240) /workspaces/dora/pkg/danger/danger_test.go:94 +0x1e5 fp=0xc000067e48 sp=0xc000067de8 pc=0x5a8ee5 testing.(*B).runN(0xc00016a240, 0x1) /usr/local/go/src/testing/benchmark.go:192 +0x1c6 fp=0xc000067f68 sp=0xc000067e48 pc=0x52fd66 testing.(*B).run1.func1(0xc00016a240) /usr/local/go/src/testing/benchmark.go:232 +0x76 fp=0xc000067fd8 sp=0xc000067f68 pc=0x541776 runtime.goexit() /usr/local/go/src/runtime/asm_amd64.s:1371 +0x1 fp=0xc000067fe0 sp=0xc000067fd8 pc=0x4a1581 created by testing.(*B).run1 /usr/local/go/src/testing/benchmark.go:225 +0x94 goroutine 1 [chan receive]: testing.(*B).run1(0xc00016a240, 0xc00020e008) /usr/local/go/src/testing/benchmark.go:234 +0xcd testing.(*B).Run(0xc00016a000, 0x5ef95a, 0x1c, 0x5f4c80, 0x6fa700) /usr/local/go/src/testing/benchmark.go:667 +0x6ec testing.runBenchmarks.func1(0xc00016a000) /usr/local/go/src/testing/benchmark.go:541 +0xa7 testing.(*B).runN(0xc00016a000, 0x1) /usr/local/go/src/testing/benchmark.go:192 +0x1c6 testing.runBenchmarks(0x5f305c, 0x2c, 0xc00013c018, 0x6f6820, 0x4, 0x4, 0x6fa7a0) /usr/local/go/src/testing/benchmark.go:550 +0x738 testing.(*M).Run(0xc00023e000, 0x0) /usr/local/go/src/testing/testing.go:1423 +0x77f main.main() _testmain.go:53 +0x237 exit status 2 FAIL github.com/bradford-hamilton/dora/pkg/danger 3.810s
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the bug:
When running
make test
the tests for thedanger
package fail.What version of Go are you using (
go version
)?To Reproduce:
Run
make test
onmaster
branchExpected behavior:
All tests pass
Screenshots:
The text was updated successfully, but these errors were encountered: