-
Notifications
You must be signed in to change notification settings - Fork 168
BM-1603: Add povw/staking/delegation API #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| pub use get_rewards_delegates::{get_rewards_delegates, ZkcGetRewardsDelegates}; | ||
| pub use get_staked_amount::{get_staked_amount, ZkcGetStakedAmount}; | ||
| pub use stake::ZkcStake; | ||
| pub use summary::ZkcSummary; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should maybe hide this one behind a experimental or unstable feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a highly requested feature, and would be one of the most used commands (as it can be used multiple times an epoch across many epochs). I would recommend, if we can, to make this feature stable asap; see my comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a highly requested feature, and would be one of the most used commands (as it can be used multiple times an epoch across many epochs). I would recommend, if we can, to make this feature stable asap; see my comment below.
Agree, looking forward to this, urgently needed.
|
This is really helpful @willpote; I have had exact feedback asking for this CLI feature many times over the past 48 hours. I would suggest we make this feature live as soon as we can; this will really help provers understand and therefore help faciliate participation in the market and PoVW. I wouldn't mark it as experimental, the only other option really is a web UI where provers can connect various addresses to see this visually, which has also been requested. If we do decide to go that route, that would take some time, and regardless there are always provers who prefer CLI commands like this for scripting reasons etc. |
Sounds good. Will try and get it stable today. |
| { | ||
| Effect: 'Allow', | ||
| Action: ['logs:CreateLogStream', 'logs:PutLogEvents'], | ||
| Resource: '*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to find a way to neck this down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored so we create the Cloudwatch policy in the Market indexer + Reward indexer stack themselves, rather than this shared infra stack, so I can get the log group names
|
🚀 Documentation Preview Deployment URL: https://boundless-documentation-1yku1157d-boundless-network.vercel.app Updated at: 2025-10-02 18:06:48 UTC |
Indexes rewards information and serves the data via an API. Will be integrated into the explorer and the CLI. To do this I:
market-indexerandreward-indexer, conditionally based on the Pulumi config. E.g. on Eth Mainnet, we don't have a Boundless market, so we only deploy thereward-indexerinPulumi.config.1.yaml