Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache guest binaries downloaded from IPFS #388

Closed
nategraf opened this issue Mar 11, 2025 · 2 comments · Fixed by #393
Closed

Cache guest binaries downloaded from IPFS #388

nategraf opened this issue Mar 11, 2025 · 2 comments · Fixed by #393
Labels
broker

Comments

@nategraf
Copy link
Member

Right now, the broker downloads the application guest image on every job, and additionally downloads the set builder and assessor guests when starting the process. This is a source of extra bandwidth costs and time cost for request evaluation, and (more importantly) has been a source of downtime when IPFS gateway rate limits are hit.

One concrete step to improve on this is to cache the content downloaded from IPFS URLs. Because IPFS is content addressable, it is possible to use the CID int the URL as the cache key. Caching the set builder and the assessor images would be obvious and immediately helpful. Caching application guest images would also be quite helpful, but requires a heuristic for cache invalidation and a cap on the total cache size.
@linear Linear
Copy link

linear bot commented Mar 11, 2025

BM-615 Cache guest binaries downloaded from IPFS

@willpote
Copy link
Contributor

When we upload these images lets also make sure we use a subscribed pinata account, as that enables a higher request limit

@linear linear bot added the broker label Mar 11, 2025
@willemolding willemolding mentioned this issue Mar 12, 2025
Merged
willemolding added a commit that referenced this issue Mar 20, 2025
@willemolding @austinabell
@nahoc @sashaaldrick @willpote @mothran @nategraf @rlukata @zeroecco @capossele
BM-615 - Add caching for assessor and set builder images (#393)
6e8ba39 
Closes #388 

Uses reqwest middleware to add a HTTP-aware cache. See
https://docs.rs/http-cache-reqwest/latest/http_cache_reqwest/index.html.
This is used only for caching requests for assessor and set-builder
images at this time.

- Adds caching to requests to retrieve assessor and set builder images
- - Can trivially also add it to user images but this may need more
discussion
- Add new command line flag `--cache-images` to broker
- Adds new command line arg `--cache-dir` to broker (default
`/tmp/broker_cache/`)

---------

Co-authored-by: Austin Abell <[email protected]>
Co-authored-by: Cohan <[email protected]>
Co-authored-by: Sasha <[email protected]>
Co-authored-by: pote.eth <[email protected]>
Co-authored-by: Parker Thompson <[email protected]>
Co-authored-by: Victor Graf <[email protected]>
Co-authored-by: Rami Lukata <[email protected]>
Co-authored-by: Richard Howard <[email protected]>
Co-authored-by: Angelo Capossele <[email protected]>
nategraf added a commit that referenced this issue Mar 20, 2025
@willemolding @austinabell
@nahoc @sashaaldrick @willpote @mothran @nategraf @rlukata @zeroecco @capossele
BM-615 - Add caching for assessor and set builder images (#393)
d127ff3 
Closes #388 

Uses reqwest middleware to add a HTTP-aware cache. See
https://docs.rs/http-cache-reqwest/latest/http_cache_reqwest/index.html.
This is used only for caching requests for assessor and set-builder
images at this time.

- Adds caching to requests to retrieve assessor and set builder images
- - Can trivially also add it to user images but this may need more
discussion
- Add new command line flag `--cache-images` to broker
- Adds new command line arg `--cache-dir` to broker (default
`/tmp/broker_cache/`)

---------

Co-authored-by: Austin Abell <[email protected]>
Co-authored-by: Cohan <[email protected]>
Co-authored-by: Sasha <[email protected]>
Co-authored-by: pote.eth <[email protected]>
Co-authored-by: Parker Thompson <[email protected]>
Co-authored-by: Victor Graf <[email protected]>
Co-authored-by: Rami Lukata <[email protected]>
Co-authored-by: Richard Howard <[email protected]>
Co-authored-by: Angelo Capossele <[email protected]>
nategraf added a commit that referenced this issue Mar 20, 2025
@willemolding @austinabell
@nahoc @sashaaldrick @willpote @mothran @nategraf @rlukata @zeroecco @capossele
BM-615 - Add caching for assessor and set builder images (#393)
578254b 
Closes #388 

Uses reqwest middleware to add a HTTP-aware cache. See
https://docs.rs/http-cache-reqwest/latest/http_cache_reqwest/index.html.
This is used only for caching requests for assessor and set-builder
images at this time.

- Adds caching to requests to retrieve assessor and set builder images
- - Can trivially also add it to user images but this may need more
discussion
- Add new command line flag `--cache-images` to broker
- Adds new command line arg `--cache-dir` to broker (default
`/tmp/broker_cache/`)

---------

Co-authored-by: Austin Abell <[email protected]>
Co-authored-by: Cohan <[email protected]>
Co-authored-by: Sasha <[email protected]>
Co-authored-by: pote.eth <[email protected]>
Co-authored-by: Parker Thompson <[email protected]>
Co-authored-by: Victor Graf <[email protected]>
Co-authored-by: Rami Lukata <[email protected]>
Co-authored-by: Richard Howard <[email protected]>
Co-authored-by: Angelo Capossele <[email protected]>
nategraf added a commit that referenced this issue Mar 21, 2025
@willemolding @austinabell
@nahoc @sashaaldrick @willpote @mothran @nategraf @rlukata @zeroecco @capossele
BM-615 - Add caching for assessor and set builder images (#393)
53ebfd3 
Closes #388 

Uses reqwest middleware to add a HTTP-aware cache. See
https://docs.rs/http-cache-reqwest/latest/http_cache_reqwest/index.html.
This is used only for caching requests for assessor and set-builder
images at this time.

- Adds caching to requests to retrieve assessor and set builder images
- - Can trivially also add it to user images but this may need more
discussion
- Add new command line flag `--cache-images` to broker
- Adds new command line arg `--cache-dir` to broker (default
`/tmp/broker_cache/`)

---------

Co-authored-by: Austin Abell <[email protected]>
Co-authored-by: Cohan <[email protected]>
Co-authored-by: Sasha <[email protected]>
Co-authored-by: pote.eth <[email protected]>
Co-authored-by: Parker Thompson <[email protected]>
Co-authored-by: Victor Graf <[email protected]>
Co-authored-by: Rami Lukata <[email protected]>
Co-authored-by: Richard Howard <[email protected]>
Co-authored-by: Angelo Capossele <[email protected]>
nategraf added a commit that referenced this issue Mar 21, 2025
@willemolding @austinabell
@nahoc @sashaaldrick @willpote @mothran @nategraf @rlukata @zeroecco @capossele
BM-615 - Add caching for assessor and set builder images (#393)
01c4d06 
Closes #388 

Uses reqwest middleware to add a HTTP-aware cache. See
https://docs.rs/http-cache-reqwest/latest/http_cache_reqwest/index.html.
This is used only for caching requests for assessor and set-builder
images at this time.

- Adds caching to requests to retrieve assessor and set builder images
- - Can trivially also add it to user images but this may need more
discussion
- Add new command line flag `--cache-images` to broker
- Adds new command line arg `--cache-dir` to broker (default
`/tmp/broker_cache/`)

---------

Co-authored-by: Austin Abell <[email protected]>
Co-authored-by: Cohan <[email protected]>
Co-authored-by: Sasha <[email protected]>
Co-authored-by: pote.eth <[email protected]>
Co-authored-by: Parker Thompson <[email protected]>
Co-authored-by: Victor Graf <[email protected]>
Co-authored-by: Rami Lukata <[email protected]>
Co-authored-by: Richard Howard <[email protected]>
Co-authored-by: Angelo Capossele <[email protected]>
nategraf added a commit that referenced this issue Mar 21, 2025
@willemolding @austinabell
@nahoc @sashaaldrick @willpote @mothran @nategraf @rlukata @zeroecco @capossele
BM-615 - Add caching for assessor and set builder images (#393)
33b70f6 
Closes #388 

Uses reqwest middleware to add a HTTP-aware cache. See
https://docs.rs/http-cache-reqwest/latest/http_cache_reqwest/index.html.
This is used only for caching requests for assessor and set-builder
images at this time.

- Adds caching to requests to retrieve assessor and set builder images
- - Can trivially also add it to user images but this may need more
discussion
- Add new command line flag `--cache-images` to broker
- Adds new command line arg `--cache-dir` to broker (default
`/tmp/broker_cache/`)

---------

Co-authored-by: Austin Abell <[email protected]>
Co-authored-by: Cohan <[email protected]>
Co-authored-by: Sasha <[email protected]>
Co-authored-by: pote.eth <[email protected]>
Co-authored-by: Parker Thompson <[email protected]>
Co-authored-by: Victor Graf <[email protected]>
Co-authored-by: Rami Lukata <[email protected]>
Co-authored-by: Richard Howard <[email protected]>
Co-authored-by: Angelo Capossele <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
broker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BM-615 - Add caching for assessor and set builder images boundless-xyz/boundless
2 participants
@nategraf @willpote