Wrap HybridBayesNet and HybridConditional methods #2152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@varunagrawal added a prune test in DiscreteBN |
Contributor
|
Merging so I can look into the TODOs more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second step in more careful wrapper changes that were part of #2120 and thoroughly unit test hybrid.
This adds HybridBayesNet and HybridCondtitional notebooks, and changed to wrapper needed to make this happen.
@varunagrawal take a close look at TODOs in test_HybridBayesNet.py and also see issue #2146. I am not convinced the behavior for prune is how we want it - so we should meet and discuss. If something needs fixing we can fix it in this PR or a follow-up PR.
This does make a choice to expose AlgebraicDecisionTreeKey and adds AssignmentKey in hybrid.h.