Avoid assertion failures in deinitializers (thebrowsercompany#168)

Author: bootuz

Sources/WebDriver/Poll.swift

@@ -5,7 +5,7 @@ import struct Dispatch.DispatchTime
 /// Calls a closure repeatedly with exponential backoff until it reports success or a timeout elapses.
 /// Thrown errors bubble up immediately, returned errors allow retries.
 /// - Returns: The successful value.
-internal func poll<Value>(
+public func poll<Value>(
         timeout: TimeInterval,
         initialPeriod: TimeInterval = 0.001,
         work: () throws -> Result<Value, Error>) throws -> Value {
@@ -33,7 +33,7 @@ internal func poll<Value>(
 
 /// Calls a closure repeatedly with exponential backoff until it reports success or a timeout elapses.
 /// - Returns: Whether the closure reported success within the expected time.
-internal func poll(
+public func poll(
         timeout: TimeInterval,
         initialPeriod: TimeInterval = 0.001,
         work: () throws -> Bool) throws -> Bool {

Sources/WebDriver/Session.swift

@@ -363,11 +363,6 @@ public class Session {
     }
 
     deinit {
-        do { try delete() }
-        catch let error as ErrorResponse {
-            assertionFailure("Error in Session.delete: \(error)")
-        } catch {
-            assertionFailure("Unexpected error in Session.delete: \(error)")
-        }
+        try? delete() // Call `delete` directly to handle errors.
     }
 }

Sources/WinAppDriver/WinAppDriver.swift

@@ -18,9 +18,9 @@ public class WinAppDriver: WebDriver {
     public static let defaultStartWaitTime: TimeInterval = 1.0
 
     private let httpWebDriver: HTTPWebDriver
-    private let processTree: Win32ProcessTree?
+    private var processTree: Win32ProcessTree?
     /// The write end of a pipe that is connected to the child process's stdin.
-    private let childStdinHandle: HANDLE?
+    private var childStdinHandle: HANDLE?
 
     private init(
         httpWebDriver: HTTPWebDriver,
@@ -115,16 +115,7 @@ public class WinAppDriver: WebDriver {
     }
 
     deinit {
-        if let processTree {
-            do {
-                try processTree.terminate(waitTime: TimeInterval.infinity)
-            } catch {
-                assertionFailure("WinAppDriver did not terminate within the expected time: \(error).")
-            }
-        }
-        if let childStdinHandle {
-            CloseHandle(childStdinHandle)
-        }
+        try? close() // Call close() directly to handle errors. 
     }
 
     @discardableResult
@@ -135,4 +126,16 @@ public class WinAppDriver: WebDriver {
     public func isInconclusiveInteraction(error: ErrorResponse.Status) -> Bool {
         error == .winAppDriver_elementNotInteractable || httpWebDriver.isInconclusiveInteraction(error: error)
     }
+
+    public func close() throws {
+        if let childStdinHandle {
+            CloseHandle(childStdinHandle)
+            self.childStdinHandle = nil
+        }
+
+        if let processTree {
+            try processTree.terminate(waitTime: TimeInterval.infinity)
+            self.processTree = nil
+        }
+    }
 }