Skip to content

lru_cache, remove redundant copy when updating queue position #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

lru_cache, remove redundant copy when updating queue position #867

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62d98e7
lru_cache, remove redundant copy when updating queue position
Aug 19, 2021
5f09d4f
review update 1. fix return to reference iterator rather than the no …
Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions include/boost/compute/detail/lru_cache.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,7 @@ class lru_cache
m_list.push_front(key);

// update iterator in map
j = m_list.begin();
const value_type &value = i->second.first;
m_map[key] = std::make_pair(value, j);
i->second.second = m_list.begin();

// return the value
return value;
Copy link

@faker2048 faker2048 Oct 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the value from.

Copy link
Author

@Hailios Hailios Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I forgot to update it. updated the PR now :)

Expand Down