You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Integration of sml as 3rdparty library shouldn't lead to cmake targets conflicts
Actual Behavior
The integration of sml with cmake leads to a conflict target "logging" from the examples which is enough generic to potentially conflict within an existing large project.
I would expect to control cmake targets with options SML_BUILD_EXAMPLES set to OFF. But the inclusion of examples is not conditioned by this flag. I would suggest to include examples only if SML_BUILD_EXAMPLES=ON. The same reasoning could apply to other flags SML_BUILD_BENCHMARKS and SML_BUILD_TESTS
Specifications
Version: 1.1.6
Platform: Ubuntu 22.04
Subsystem:
The text was updated successfully, but these errors were encountered:
Expected Behavior
Integration of sml as 3rdparty library shouldn't lead to cmake targets conflicts
Actual Behavior
The integration of sml with cmake leads to a conflict target "logging" from the examples which is enough generic to potentially conflict within an existing large project.
I would expect to control cmake targets with options SML_BUILD_EXAMPLES set to OFF. But the inclusion of examples is not conditioned by this flag. I would suggest to include examples only if SML_BUILD_EXAMPLES=ON. The same reasoning could apply to other flags SML_BUILD_BENCHMARKS and SML_BUILD_TESTS
Specifications
The text was updated successfully, but these errors were encountered: