Update workspace versions when running bolt add on an existing dependency in the project root (#251)

* Update workspace versions when running bolt add on an existing dependency in the project root

* Fix flow errors

Author: Blasz

src/utils/__tests__/addDependenciesToPackages.test.js

@@ -142,6 +142,52 @@ describe('utils/addDependenciesToPackages', () => {
     expect(pkg.getDependencyVersionRange('project-only-dep')).toEqual('^1.0.0');
   });
 
+  test('should update all package dependencies when run from project root', async () => {
+    let cwd = f.copy('package-with-external-deps-installed');
+    let project = await Project.init(cwd);
+    let packages = await project.getPackages();
+    let fooPkg = project.getPackageByName(packages, 'foo');
+    let barPkg = project.getPackageByName(packages, 'bar');
+    if (!fooPkg || !barPkg) {
+      // This check is required to satisfy flow
+      throw new Error('missing packages');
+    }
+
+    expect(project.pkg.getDependencyVersionRange('global-dep')).toEqual(
+      '^1.0.0'
+    );
+    expect(fooPkg.getDependencyVersionRange('global-dep')).toEqual('^1.0.0');
+    expect(barPkg.getDependencyVersionRange('global-dep')).toEqual('^1.0.0');
+
+    expect(project.pkg.getDependencyVersionRange('foo-dep')).toEqual('^1.0.0');
+    expect(fooPkg.getDependencyVersionRange('foo-dep')).toEqual('^1.0.0');
+    expect(barPkg.getDependencyVersionRange('foo-dep')).toEqual(null);
+
+    await addDependenciesToPackage(project, project.pkg, [
+      { name: 'global-dep', version: '^1.1.0' },
+      { name: 'foo-dep', version: '^1.2.0' }
+    ]);
+
+    // Refetch packages as their config will be stale
+    packages = await project.getPackages();
+    fooPkg = project.getPackageByName(packages, 'foo');
+    barPkg = project.getPackageByName(packages, 'bar');
+    if (!fooPkg || !barPkg) {
+      // This check is required to satisfy flow
+      throw new Error('missing packages');
+    }
+
+    expect(project.pkg.getDependencyVersionRange('global-dep')).toEqual(
+      '^1.1.0'
+    );
+    expect(fooPkg.getDependencyVersionRange('global-dep')).toEqual('^1.1.0');
+    expect(barPkg.getDependencyVersionRange('global-dep')).toEqual('^1.1.0');
+
+    expect(project.pkg.getDependencyVersionRange('foo-dep')).toEqual('^1.2.0');
+    expect(fooPkg.getDependencyVersionRange('foo-dep')).toEqual('^1.2.0');
+    expect(barPkg.getDependencyVersionRange('foo-dep')).toEqual(null);
+  });
+
   test('should be able to add packages with tagged versions (without specifying)', async () => {
     let cwd = f.copy('package-with-external-deps-installed');
     let project = await Project.init(cwd);

src/utils/addDependenciesToPackages.js

@@ -10,6 +10,7 @@ import { BoltError } from './errors';
 import * as logger from './logger';
 import * as yarn from './yarn';
 import symlinkPackageDependencies from './symlinkPackageDependencies';
+import updateWorkspaceDependencies from '../functions/updateWorkspaceDependencies';
 
 export default async function addDependenciesToPackage(
   project: Project,
@@ -43,6 +44,15 @@ export default async function addDependenciesToPackage(
         messages.cannotInstallWorkspaceInProject(internalDeps[0].name)
       );
     }
+
+    // Update all workspace versions
+    const depsToUpgrade = externalDeps.reduce((prev, dep) => {
+      prev[dep.name] = dep.version;
+      return prev;
+    }, {});
+    await updateWorkspaceDependencies(depsToUpgrade, {
+      cwd: project.pkg.dir
+    });
     return true;
   }