Java annotation is treated as Boa modifier causing stack empty exception

[nguyenhoan]

compiler/src/java/boa/datagen/util/Java7Visitor.java

Line 837 in 086f06b

sb.setExpression(expressions.pop());

When the default expression is an annotation.
A modifier will be generated instead of an expression.

[nguyenhoan]

An ugly solution is to check all relevant global stacks and pop the one that is not empty.
Any others?

[psybers]

Why not test the type of getDefault() and pop the modifiers if its an annotation, or pop expression otherwise?

[nguyenhoan]

That's ugly :).
We might need to check all locations of pop() to make sure we did not miss anything.

[psybers]

It's ugly, but less ugly than your suggestion (which is actually wrong - it's possible other stacks might not be empty at that point due to nested classes). And it actually makes sense if they child could be multiple things. The question is though, if we get a modifier what do we stick into Boa's AST?

[nguyenhoan]

I thought it was a statement but it is actually a method.