feat: add serviceAccount and extraVolumes #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultserti
changed the title
thibaultserti
force-pushed
the
feat/add-sa-extravolumes
branch
from
0369423 to
14c3551
Compare
thibaultserti
force-pushed
the
feat/add-sa-extravolumes
branch
from
14c3551 to
eca398a
Compare
|
Is this still a draft? |
bman46
changed the title
bman46
requested changes
Aug 31, 2023
| @@ -15,6 +15,15 @@ security: | |||
| runAsNonRoot: true | |||
| runAsUser: 1001 | |||
|
|
|||
| serviceAccount: | |||
| create: true | |||
There was a problem hiding this comment.
Should this be defaulted to false?
|
Yes |
|
In fact, I need to change many things to make it work for me. I don't have much time in the next few days, I'll try to do this when I can free some time. |
|
All good. Just mark this PR as ready when you get time to complete it and I'll review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36