Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out bluesky-tiled-plugins package #814

Merged
merged 13 commits into from
Jan 16, 2025
Merged

Factor out bluesky-tiled-plugins package #814

merged 13 commits into from
Jan 16, 2025

Conversation

danielballan
Copy link
Member

@danielballan danielballan commented Jun 20, 2024 •
edited
Loading

This creates a second Python package in the databroker repository, bluesky-tiled-plugins, with the "special client" objects BlueskyRun, BlueskyEventStream, and CatalogOfBlueskyRuns, as well as the custom query objects PartialUID, ScanID, and TimeRange. Quoting the README:

For a user wishing to connect to a running Tiled server and access Bluesky data,
this package, along with its dependency tiled[client], is all they need.

The databroker package is only required if the user wants to use the legacy
databroker.Broker API.

This means it is no longer necessary to install databroker in the client environment unless they have legacy databroker.Broker code.

To be clear, the server environment still needs databroker.mongo_normalized, the Tiled Adapter for MongoDB with Bluesky document collections.

This is a backward-compatible change. Databroker now has a dependency on bluesky-tiled-plugins and has shim modules that expose the moved objects at the original locations within the databroker package.

Closes #812

@danielballan danielballan requested a review from tacaswell June 20, 2024 16:35
@danielballan
Copy link
Member Author

I have registered the publish-pypi.yml workflow in this repository as a "pending" trusted publisher such that merge this PR should create the bluesky-tiled-plugins package on PyPI.

@danielballan danielballan force-pushed the bluesky-tiled-plugins branch from 6485707 to 491a1b3 Compare January 16, 2025 14:45
@danielballan
Copy link
Member Author

One transient failure, unrelated to the change:

FAILED databroker/assets/tests/test_write.py::test_multi_write_fail[sqlite] - TimeoutError: cursor call timed out

@danielballan danielballan merged commit e62d9e3 into bluesky:main Jan 16, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell Awaiting requested review from tacaswell

@padraic-shafer padraic-shafer Awaiting requested review from padraic-shafer

@AbbyGi AbbyGi Awaiting requested review from AbbyGi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Tiled plugins into separate package
1 participant
@danielballan