Skip to content

Hide memory graph button for temporal flamegraph #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ruchika2ar
Copy link
Contributor

*Issue number of the reported bug or feature request: #712 *

Describe your changes
Temporal graph already shows the temporal graph for memory usage. Hide the button in topbar for the same.

Testing performed
Tested locally with and without --temporal argument.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (80a3baa) to head (1cd8763).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
- Coverage   92.96%   92.78%   -0.18%     
==========================================
  Files          95       95              
  Lines       11686    11686              
  Branches      407      407              
==========================================
- Hits        10864    10843      -21     
- Misses        822      843      +21     
Flag Coverage Δ
cpp 92.78% <ø> (-0.18%) ⬇️
python_and_cython 92.78% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sarahmonod sarahmonod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Ruchika!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants