Constants and classes MariaDB COM_STMT_BULK_EXECUTE command #173
+206
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added StmtBulkExecuteParamsFlags bitflags for packet's bulk flags and MariadbBulkIndicator enum to define possible paramater value indicators. Added ComStmtBulkExecuteRequestBuilder class to build COM_STMT_BULK_EXECUTE packet representation in ComStmtBulkExecuteRequest class implementing packet data serialization.
Contributor
Author
|
I see that compilation failed in the actions. I'll fix this. Locally it compiles for me. Btw we have the ticket for this task in our Jira, and we have tickets for everything we are planning atm to implement and contribute. |
blackbeam
reviewed
Nov 10, 2025
| } | ||
| } | ||
|
|
||
| pub fn next(&mut self) -> () { |
Owner
There was a problem hiding this comment.
Could you please document the meaning of all the public functions?
blackbeam
reviewed
Nov 10, 2025
| .0 | ||
| .contains(StmtBulkExecuteParamsFlags::SEND_TYPES_TO_SERVER) | ||
| { | ||
| for param in &self.params[0] { |
Owner
There was a problem hiding this comment.
Hmm. This will panic if SEND_TYPES_TO_SERVER is set and the params is empty that seems reachable from ComStmtBulkExecuteRequestBuilder 🤔
blackbeam
reviewed
Nov 10, 2025
| self.paramset.clear(); | ||
| self.payload_len = 0; | ||
| } | ||
| pub fn add_row(&mut self, params: &[Value]) -> bool { |
Owner
There was a problem hiding this comment.
This should be add_row(&mut self, params: Vec<Value>) I believe, to avoid unnecessary clone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for MariaDB bulk execution using COM_STMT_BULK_EXECUTE command.
mysql-simple PR is to follow.
I'm submitting this pull request on behalf of my employer, MariaDB corporation