Make Basic.has behave more like SymPy, use new visitor

Author: bjodah

symengine/__init__.py

@@ -19,7 +19,7 @@
     Max, Min, DenseMatrix, Matrix,
     ImmutableMatrix, ImmutableDenseMatrix, MutableDenseMatrix,
     MatrixBase, Basic, DictBasic, symarray, series, diff, zeros,
-    eye, diag, ones, Derivative, Subs, expand, has_symbol,
+    eye, diag, ones, Derivative, Subs, expand, has_basic, has_symbol,
     UndefFunction, Function, UnevaluatedExpr, latex,
     have_numpy, true, false, Equality, Unequality, GreaterThan,
     LessThan, StrictGreaterThan, StrictLessThan, Eq, Ne, Ge, Le,

symengine/lib/symengine.pxd

@@ -771,6 +771,7 @@ cdef extern from "<symengine/prime_sieve.h>" namespace "SymEngine":
         unsigned next_prime() nogil
 
 cdef extern from "<symengine/visitor.h>" namespace "SymEngine":
+    bool has_basic(const Basic &b, const Basic &x) except + nogil
     bool has_symbol(const Basic &b, const Basic &x) except + nogil
     rcp_const_basic coeff(const Basic &b, const Basic &x, const Basic &n) except + nogil
     set_basic free_symbols(const Basic &b) except + nogil

symengine/lib/symengine_wrapper.in.pyx

@@ -1187,8 +1187,11 @@ cdef class Basic(object):
         cdef Basic _n = sympify(n)
         return c2py(symengine.coeff(deref(self.thisptr), deref(_x.thisptr), deref(_n.thisptr)))
 
-    def has(self, *symbols):
-        return any([has_symbol(self, symbol) for symbol in symbols])
+    def has(self, *args):
+        for arg in args:
+            if has_basic(self, arg):
+                return True
+        return False
 
     def args_as_sage(Basic self):
         cdef symengine.vec_basic Y = deref(self.thisptr).get_args()
@@ -4966,6 +4969,11 @@ def powermod_list(a, b, m):
         s.append(c2py(<rcp_const_basic>(v[i])))
     return s
 
+def has_basic(obj, looking_for=None):
+    cdef Basic b = _sympify(obj)
+    cdef Basic s = _sympify(looking_for)
+    return symengine.has_basic(deref(b.thisptr), deref(s.thisptr))
+
 def has_symbol(obj, symbol=None):
     cdef Basic b = _sympify(obj)
     cdef Basic s = _sympify(symbol)

symengine/tests/test_expr.py

@@ -28,8 +28,16 @@ def test_as_powers_dict():
     assert (2**-y).as_powers_dict() == {2: -y}
 
 
-def test_has():
+def test_Basic__has():
     x = Symbol('x')
+    y = Symbol('y')
+    xp3 = (x+3)
+    ym4 = (y-4)
+    e = xp3**ym4
+    assert e.has(xp3)
+    assert e.has(ym4)
+    assert not e.has(y-5)
+
     assert (x + oo).has(oo)
     assert (x - oo).has(-oo)
     assert not (x + oo).has(-oo)

symengine/tests/test_functions.py

@@ -86,6 +86,7 @@ def test_derivative():
 
     fxy = Function("f")(x, y)
     assert (1+fxy).has(fxy)
+    assert (1+fxy).has(1)
     g = Derivative(Function("f")(x, y), x, 2, y, 1)
     assert g == fxy.diff(x, x, y)
     assert g == fxy.diff(y, 1, x, 2)

symengine/tests/test_number.py

@@ -1,6 +1,6 @@
 from symengine.test_utilities import raises
 
-from symengine import Integer, I, S, Symbol, pi, Rational
+from symengine import Integer, I, S, Symbol, pi, Rational, has_basic
 from symengine.lib.symengine_wrapper import (perfect_power, is_square, integer_nthroot)
 
 
@@ -100,6 +100,10 @@ def test_is_conditions():
     assert pi.is_Atom
 
 
+def test_has_basic():
+    assert has_basic(3 + pi, pi)
+
+
 def test_perfect_power():
     assert perfect_power(1) == True
     assert perfect_power(7) == False

symengine_version.txt

@@ -1 +1 @@
-c9510fb4b5c30b84adb993573a51f2a9a38a4cfe
+10d3591214e3f5906106f35ed19b6428b3fd86a3