Skip to content
This repository was archived by the owner on Dec 3, 2018. It is now read-only.

Option not to load url rules on bootstrap #109

Open
SDKiller opened this issue May 12, 2017 · 3 comments
Open

Option not to load url rules on bootstrap #109

SDKiller opened this issue May 12, 2017 · 3 comments
Milestone

Comments

@SDKiller
Copy link

SDKiller commented May 12, 2017

Cuurently Podium appends its url rules on bootstrap

https://github.com/bizley/yii2-podium/blob/master/src/Podium.php#L214

This has 2 drawbacks:

  1. possible undesired order of url rules (application-wide - consider that there are other modules and their corresponding rules)
  2. not a trivial task of customizing Podium rules

IMO there could be a config option to load default rules as it is done now or switch off this bootstrap task and define Podium url rules in application config.

@bizley
Copy link
Owner

bizley commented May 12, 2017

It's true especially for 2. The first one should be collision free because of the custom name you can set for the module. Still, option to shut it off sounds good.

@bizley bizley added this to the 0.8 milestone May 12, 2017
@SDKiller
Copy link
Author

SDKiller commented May 12, 2017

The first one should be collision free

I talk not about name collisions, but cases when you desire to set rules order explicitly - what should be checked first and what last. Maybe you have some "fallback" rules in the end to catch other requests.

@bizley
Copy link
Owner

bizley commented May 13, 2017

Podium rules are appended.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants