Skip to content

Commit 0eba924

Browse files
authored
[PM-20288] Fix GitHub Release creation in sdk-swift repo (#459)
## ๐ŸŽŸ๏ธ Tracking PM-20288 ## ๐Ÿ“” Objective Fix GitHub Release creation in sdk-swift repo. The BitwardenFFI zip wasn't being found due to running in the wrong path. Test runs: * https://github.com/bitwarden/sdk-internal/actions/runs/17779143466 * https://github.com/bitwarden/ios/actions/runs/17779169149 * bitwarden/ios#1944 ## โฐ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## ๐Ÿฆฎ Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - ๐Ÿ‘ (`:+1:`) or similar for great changes - ๐Ÿ“ (`:memo:`) or โ„น๏ธ (`:information_source:`) for notes or general info - โ“ (`:question:`) for questions - ๐Ÿค” (`:thinking:`) or ๐Ÿ’ญ (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - ๐ŸŽจ (`:art:`) for suggestions / improvements - โŒ (`:x:`) or โš ๏ธ (`:warning:`) for more significant problems or concerns needing attention - ๐ŸŒฑ (`:seedling:`) or โ™ป๏ธ (`:recycle:`) for future improvements or indications of technical debt - โ› (`:pick:`) for minor or nitpick changes
1 parent 0f493c2 commit 0eba924

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

โ€Ž.github/workflows/release-swift.ymlโ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,6 @@ jobs:
217217
_RELEASE_NAME: ${{ steps.set-release-name.outputs.release_name }}
218218
_PKG_VERSION: ${{ steps.version.outputs.version }}
219219
_SDK_INTERNAL_SHORT_REF: ${{ steps.get-sdk-internal-ref.outputs.short_sha }}
220-
working-directory: sdk
221220
run: |
222221
gh release create "v$_RELEASE_NAME" \
223222
--repo bitwarden/sdk-swift \

0 commit comments

Comments
ย (0)